attach Stream.toReadableStream fibers to scope (#2834)

Effect-TS · May 23, 2024 · 031c712 · 031c712
1 parent 5133ca9
commit 031c712
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 3 deletions.
diff --git a/.changeset/metal-parrots-approve.md b/.changeset/metal-parrots-approve.md
@@ -0,0 +1,5 @@
+---
+"effect": patch
+---
+
+attach Stream.toReadableStream fibers to scope
diff --git a/packages/effect/src/internal/stream.ts b/packages/effect/src/internal/stream.ts
@@ -6555,7 +6555,7 @@ export const toReadableStreamRuntime = dual<
   <A, E, XR, R extends XR>(self: Stream.Stream<A, E, R>, runtime: Runtime.Runtime<XR>) => ReadableStream<A>
 >(2, <A, E, XR, R extends XR>(self: Stream.Stream<A, E, R>, runtime: Runtime.Runtime<XR>): ReadableStream<A> => {
   const runSync = Runtime.runSync(runtime)
-  const runPromise = Runtime.runPromise(runtime)
+  const runFork = Runtime.runFork(runtime)
 
   let pull: Effect.Effect<void, never, R>
   let scope: Scope.CloseableScope
@@ -6588,10 +6588,14 @@ export const toReadableStreamRuntime = dual<
       )
     },
     pull() {
-      return runPromise(pull)
+      return new Promise<void>((resolve) => {
+        runFork(pull, { scope }).addObserver((_) => resolve())
+      })
     },
     cancel() {
-      return runPromise(Scope.close(scope, Exit.void))
+      return new Promise<void>((resolve) => {
+        runFork(Scope.close(scope, Exit.void)).addObserver((_) => resolve())
+      })
     }
   })
 })