Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ap method to Effect, ap and zipWith to Either ⚡️ #1504

Merged
merged 7 commits into from Oct 9, 2023

Conversation

kutyel
Copy link
Contributor

@kutyel kutyel commented Oct 9, 2023

Fixes #1502

@changeset-bot
Copy link

changeset-bot bot commented Oct 9, 2023

🦋 Changeset detected

Latest commit: f9a9df2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
effect Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

src/Effect.ts Show resolved Hide resolved
@kutyel kutyel requested a review from gcanti October 9, 2023 13:10
@kutyel kutyel changed the title feat: add ap method to Effect ⚡️ feat: add ap method to Effect, ap and zipWith to Either ⚡️ Oct 9, 2023
Copy link
Contributor

@gcanti gcanti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add a few tests for the 3 new APIs.

p.s.
Could you please also run pnpm docgen to generate the updated docs?

@kutyel kutyel requested a review from gcanti October 9, 2023 14:14
test/Effect/applicative.ts Outdated Show resolved Hide resolved
test/Effect/applicative.ts Outdated Show resolved Hide resolved
test/Effect/applicative.ts Outdated Show resolved Hide resolved
@kutyel kutyel requested a review from gcanti October 9, 2023 15:02
test/Effect/applicative.ts Outdated Show resolved Hide resolved
@gcanti gcanti merged commit f186416 into Effect-TS:main Oct 9, 2023
1 check passed
@gcanti
Copy link
Contributor

gcanti commented Oct 9, 2023

Thanks @kutyel

@github-actions github-actions bot mentioned this pull request Oct 9, 2023
@kutyel kutyel deleted the kutyel-adding-ap-to-effect branch October 9, 2023 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

From Discord: Lack of ap Method in Either and Effect
2 participants