use TimeoutException for timeout #1995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 6b7e812 The changes in this PR will be included in the next version bump. This PR includes changesets to release 17 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
IMax153
requested changes
Jan 29, 2024
sukovanej
force-pushed
the
timeout-exception
branch
2 times, most recently
from
2c199af
to
ccf1e1d
Compare
sukovanej
force-pushed
the
timeout-exception
branch
from
ccf1e1d
to
6b7e812
Compare
IMax153
approved these changes
Jan 29, 2024
There was a problem hiding this comment.
I personally like this change. Though it limits the use of optionFromOptional for handling timeout errors, I feel as though the explicitness is much better.
Will wait for @mikearnaldi and @tim-smart to also weigh in.
Merged
gcanti
pushed a commit
that referenced
this pull request
Feb 5, 2024
tim-smart
pushed a commit
that referenced
this pull request
Feb 6, 2024
tim-smart
pushed a commit
that referenced
this pull request
Feb 7, 2024
tim-smart
pushed a commit
that referenced
this pull request
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type
Description
I was staring at a failing test shouting
NoSuchElementExceptionat me and it took me some time to realise it is actually a timeout.While I somewhat get the point that being able to easily convert such an error to
OptionusingEffect.optionFromOptionalis convenient, I believe it is quite confusing. In such a case using explicitEffect.catchTag("TimeoutException", () => Effect.succeedNone)and communicating clearly what's happening to a reader of my code is IMHO better.