feat: Make Equal an implicit trait, namely remove the type Data.Data

[mikearnaldi]

With this change we remove the Data.Data type and we make Equal.Equal & Hash.Hash an implicit traits.

The main reason is that Data.Data<A> was structurally equivalent to A & Equal.Equal but extending Equal.Equal doesn't mean that the equality is implemented by-value, so the type was simply adding noice without gaining any level of safety.

The module Data remains unchanged at the value level, all the functions priorly available are supposed to work in exactly the same manner.

At the type level instead the functions return Readonly variants, so for example we have:

import { Data } from "effect";

const obj = Data.struct({
  a: 0,
  b: 1,
});

will have the obj typed as:

declare const obj: {
  readonly a: number;
  readonly b: number;
};

closes #1962

[changeset-bot]

🦋 Changeset detected

Latest commit: 3cfcd29

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages

Name	Type
@effect/platform	Major
effect	Minor
@effect/schema	Major
@effect/cli	Major
@effect/rpc	Major
@effect/experimental	Major
@effect/platform-browser	Major
@effect/platform-bun	Major
@effect/platform-node-shared	Major
@effect/platform-node	Major
@effect/rpc-http-node	Major
@effect/rpc-http	Major
@effect/rpc-nextjs	Major
@effect/rpc-workers	Major
@effect/opentelemetry	Major
@effect/printer-ansi	Major
@effect/printer	Major
@effect/typeclass	Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[datner]

There is a pitfall in this though, users might unwittingly squander the Data behavior and be non the wiser

pipe(
  ReadonlyArray.makeBy(10, () => new A()),
  Data.array,
  Effect.forEach(_ => Effect.as(notifyMikeAboutA(_), _))
  Effect.filterOrDie(
    Equal.equals(Data.array(ReadonlyArray.makeBy(10, () => new A()))),
    () => "w00t"
  )
) // -> it dies with w00t

[mikearnaldi]

There is a pitfall in this though, users might unwittingly squander the Data behavior and be non the wiser

pipe(
  ReadonlyArray.makeBy(10, () => new A()),
  Data.array,
  Effect.forEach(_ => Effect.as(notifyMikeAboutA(_), _))
  Effect.filterOrDie(
    Equal.equals(Data.array(ReadonlyArray.makeBy(10, () => new A()))),
    () => "w00t"
  )
) // -> it dies with w00t

That's correct as forEach returns a new copy of the array which is mutable, I guess it is a trade-off, we could also make Data.array idempotent, so that if you want to be really sure it compares correctly you can just always call it

[datner]

That's correct as forEach returns a new copy of the array which is mutable, I guess it is a trade-off, we could also make Data.array idempotent, so that if you want to be really sure it compares correctly you can just always call it

I can't come up with a solution for this pitfall, I guess we will just have to make sure to note it in the docs.

[fubhy]

I can't find any more typos 👎

Requested changes are done

[datner]

@mikearnaldi hmmm the bot (and @/gcanti 😃 ) is quite noisy here, is this a one-time or will all updates be this noisy until they publish?