Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove re-exports for platform packages #2025

Merged
merged 9 commits into from
Feb 1, 2024
Merged

remove re-exports for platform packages #2025

merged 9 commits into from
Feb 1, 2024

Conversation

tim-smart
Copy link
Member

  • add node-shared package
  • remove re-exports for platform packages

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 1, 2024 •
edited

🦋 Changeset detected

Latest commit: 8349200

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages
Name Type
@effect/platform Minor
@effect/platform-node-shared Major
@effect/platform-node Major
@effect/experimental Major
@effect/platform-bun Major
@effect/rpc-http Major
@effect/cli Major
@effect/platform-browser Major
@effect/rpc-http-node Major
@effect/rpc-nextjs Major
@effect/rpc-workers Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@tim-smart tim-smart changed the title platform reexports remove re-exports for platform packages Feb 1, 2024
@tim-smart tim-smart marked this pull request as ready for review February 1, 2024 04:34
@mikearnaldi
Copy link
Member

Currently naming is like KeyValueStoreNode, NodeContext, RuntimeNode, maybe it is more consistent to prefix everything with Node instead?

@tim-smart tim-smart changed the base branch from main to next-minor February 1, 2024 21:34
@tim-smart tim-smart removed the request for review from gcanti February 1, 2024 21:35
@tim-smart
Copy link
Member Author

Currently naming is like KeyValueStoreNode, NodeContext, RuntimeNode, maybe it is more consistent to prefix everything with Node instead?

Moved to prefixes :)

@tim-smart tim-smart merged commit 7454d6c into next-minor Feb 1, 2024
9 checks passed
@tim-smart tim-smart deleted the platform-reexports branch February 1, 2024 22:05
@github-actions github-actions bot mentioned this pull request Feb 1, 2024
Merged
github-actions bot pushed a commit that referenced this pull request Feb 3, 2024
@tim-smart
remove re-exports for platform packages (#2025)
fcbf31c
github-actions bot pushed a commit that referenced this pull request Feb 4, 2024
@tim-smart
remove re-exports for platform packages (#2025)
0b5c2b6
github-actions bot pushed a commit that referenced this pull request Feb 4, 2024
@tim-smart
remove re-exports for platform packages (#2025)
a74df68
github-actions bot pushed a commit that referenced this pull request Feb 4, 2024
@tim-smart
remove re-exports for platform packages (#2025)
09235a8
github-actions bot pushed a commit that referenced this pull request Feb 4, 2024
@tim-smart
remove re-exports for platform packages (#2025)
6434f4c
github-actions bot pushed a commit that referenced this pull request Feb 5, 2024
@tim-smart
remove re-exports for platform packages (#2025)
93e4010
gcanti pushed a commit that referenced this pull request Feb 5, 2024
@tim-smart @gcanti
remove re-exports for platform packages (#2025)
7f1c1af
tim-smart added a commit that referenced this pull request Feb 6, 2024
@tim-smart
remove re-exports for platform packages (#2025)
f37cfae
github-actions bot pushed a commit that referenced this pull request Feb 6, 2024
@tim-smart @mikearnaldi
remove re-exports for platform packages (#2025)
4d1f6af
github-actions bot pushed a commit that referenced this pull request Feb 7, 2024
@tim-smart @mikearnaldi
remove re-exports for platform packages (#2025)
4fb8691
tim-smart added a commit that referenced this pull request Feb 7, 2024
@tim-smart
remove re-exports for platform packages (#2025)
80489ac
github-actions bot pushed a commit that referenced this pull request Feb 7, 2024
@tim-smart
remove re-exports for platform packages (#2025)
39b3752
github-actions bot pushed a commit that referenced this pull request Feb 7, 2024
@tim-smart
remove re-exports for platform packages (#2025)
1759a00
github-actions bot pushed a commit that referenced this pull request Feb 7, 2024
@tim-smart
remove re-exports for platform packages (#2025)
cb1da36
@tim-smart tim-smart mentioned this pull request Feb 7, 2024
Merged
tim-smart added a commit that referenced this pull request Feb 9, 2024
@tim-smart
remove re-exports for platform packages (#2025)
b1e2086
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikearnaldi mikearnaldi Awaiting requested review from mikearnaldi

@IMax153 IMax153 Awaiting requested review from IMax153 IMax153 is a code owner

Assignees
No one assigned
Labels
next-minor
Projects
PR Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tim-smart @mikearnaldi