Rename schema transform params #2065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nspaeth
requested review from
gcanti,
tim-smart,
IMax153 and
mikearnaldi
as code owners
🦋 Changeset detectedLatest commit: 9ce874f The changes in this PR will be included in the next version bump. This PR includes changesets to release 13 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
It looks like I created this pull request incorrectly. There should only be one commit touching one file branched from I'll see if I can figure out how to fix it. |
nspaeth
force-pushed
the
rename-schema-transform-params
branch
from
1e802cd
to
d2060d8
Compare
tim-smart
force-pushed
the
rename-schema-transform-params
branch
from
d2060d8
to
b2d3704
Compare
nspaeth
force-pushed
the
rename-schema-transform-params
branch
4 times, most recently
from
83ca84a
to
8a0baca
Compare
|
Okay, fixed PR to only include my changes. |
github-actions
bot
force-pushed
the
next-minor
branch
from
8a44a87
to
c6d5930
Compare
nspaeth
force-pushed
the
rename-schema-transform-params
branch
from
8a0baca
to
9ce874f
Compare
gcanti
approved these changes
Feb 7, 2024
Merged
tim-smart
pushed a commit
that referenced
this pull request
Feb 7, 2024
tim-smart
pushed a commit
that referenced
this pull request
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type
Description
I frequently forget the types and parameters of the transform encode/decode functions and have to go look at the source and manually track the types.
This change only renames the function parameters and type parameters so that they are obvious in type hints and auto-completions.