Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize Effect.zip{Left,Right} #2099

Merged
merged 1 commit into from
Feb 11, 2024
Merged

optimize Effect.zip{Left,Right} #2099

merged 1 commit into from
Feb 11, 2024

Conversation

tim-smart
Copy link
Member

No description provided.

Copy link

changeset-bot bot commented Feb 11, 2024

🦋 Changeset detected

Latest commit: d9f4962

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 15 packages
Name Type
effect Patch
@effect/cli Patch
@effect/experimental Patch
@effect/opentelemetry Patch
@effect/platform-browser Patch
@effect/platform-bun Patch
@effect/platform-node-shared Patch
@effect/platform-node Patch
@effect/platform Patch
@effect/printer-ansi Patch
@effect/printer Patch
@effect/rpc-http Patch
@effect/rpc Patch
@effect/schema Patch
@effect/typeclass Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mikearnaldi
Copy link
Member

LGTM but we should use andThen more often that is directly using flatMap

@tim-smart
Copy link
Member Author

LGTM but we should use andThen more often that is directly using flatMap

Hah yes, need to force the habit.

@tim-smart tim-smart merged commit 1700af8 into main Feb 11, 2024
12 checks passed
@tim-smart tim-smart deleted the chore/optimize-zip branch February 11, 2024 08:56
@github-actions github-actions bot mentioned this pull request Feb 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants