Fix the return order of batched requests

[IMax153]

Type

• Refactor
• Feature
• Bug Fix
• Optimization
• Documentation Update

Description

Related

• Related Issue #
• Closes #

[changeset-bot]

🦋 Changeset detected

Latest commit: 616b2b9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 15 packages

Name	Type
effect	Patch
@effect/cli	Patch
@effect/experimental	Patch
@effect/opentelemetry	Patch
@effect/platform-browser	Patch
@effect/platform-bun	Patch
@effect/platform-node-shared	Patch
@effect/platform-node	Patch
@effect/platform	Patch
@effect/printer-ansi	Patch
@effect/printer	Patch
@effect/rpc-http	Patch
@effect/rpc	Patch
@effect/schema	Patch
@effect/typeclass	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[tim-smart]

While it works and looks good to me, I'm not sure why the behaviour changed after Mike's request refactor.

I'll defer to @mikearnaldi to review for this one :)

[mikearnaldi]

I don't think I understand the problem and by consequence the solution, would you mind writing a test?

[mikearnaldi]

While it works and looks good to me, I'm not sure why the behaviour changed after Mike's request refactor.

I'll defer to @mikearnaldi to review for this one :)

I didn't touch that function

[IMax153]

While it works and looks good to me, I'm not sure why the behaviour changed after Mike's request refactor.
I'll defer to @mikearnaldi to review for this one :)

I didn't touch that function

I was pretty convinced this was my error in the original port :) We just probably never noticed the issue before.

[IMax153]

The issue basically was - if you send a set of batched requests that were received as follows:

Request 1 -> Request 2 -> Request 3

the results were being returned as:

Result 3 -> Result 2 -> Result 1

We tracked down the inadvertent reversal of results to this method which was combining results in reverse order instead of the correct order.

I'll write a test in a separate PR - apologies for merging before seeing your messages.