Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(either): add do notation to Either #2157

Merged

Conversation

successkrisz
Copy link
Contributor

Type

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

Add the following Do notation methods to Either:

  • Either.Do
  • Either.bindTo
  • Either.bind
  • Either.let

Convention is following how it is implemented for Effects

Copy link

changeset-bot bot commented Feb 15, 2024

🦋 Changeset detected

Latest commit: 9d6c8c0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 15 packages
Name Type
effect Patch
@effect/cli Patch
@effect/experimental Patch
@effect/opentelemetry Patch
@effect/platform-browser Patch
@effect/platform-bun Patch
@effect/platform-node-shared Patch
@effect/platform-node Patch
@effect/platform Patch
@effect/printer-ansi Patch
@effect/printer Patch
@effect/rpc-http Patch
@effect/rpc Patch
@effect/schema Patch
@effect/typeclass Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot changed the base branch from main to next-minor February 15, 2024 13:06
@github-actions github-actions bot force-pushed the next-minor branch 2 times, most recently from b8f5f0e to 8b25cb9 Compare February 15, 2024 15:44
@mikearnaldi
Copy link
Member

mikearnaldi commented Feb 15, 2024

can you please rebase on next-minor, type parameters of Either have been swapped, also moving the changeset to patch as this only adds

@successkrisz
Copy link
Contributor Author

Rebased and updated 👍

@gcanti gcanti merged commit b00b008 into Effect-TS:next-minor Feb 17, 2024
12 checks passed
@github-actions github-actions bot mentioned this pull request Feb 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants