Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ManagedRuntime module, to make incremental adoption easier #2211

Merged
merged 17 commits into from
Mar 11, 2024

Conversation

tim-smart
Copy link
Member

No description provided.

Copy link

changeset-bot bot commented Feb 25, 2024

🦋 Changeset detected

Latest commit: 6e87576

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 15 packages
Name Type
effect Patch
@effect/cli Patch
@effect/experimental Patch
@effect/opentelemetry Patch
@effect/platform-browser Patch
@effect/platform-bun Patch
@effect/platform-node-shared Patch
@effect/platform-node Patch
@effect/platform Patch
@effect/printer-ansi Patch
@effect/printer Patch
@effect/rpc-http Patch
@effect/rpc Patch
@effect/schema Patch
@effect/typeclass Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mikearnaldi
Copy link
Member

not sure if this helps adoption or just induces users into a bad pattern, namely using using would lead to scope being open and closed on demand instead of having the layer survive for the program lifetime

@tim-smart
Copy link
Member Author

not sure if this helps adoption or just induces users into a bad pattern, namely using using would lead to scope being open and closed on demand instead of having the layer survive for the program lifetime

Having it implement Disposable is definitely up for debate. The main thing I wanted to tackle was providing a way to run effects in non-effect land in a nice way without having to juggle a Scope, Runtime and also memoizing the runtime.

@tim-smart tim-smart marked this pull request as ready for review February 29, 2024 23:55
@tim-smart tim-smart changed the title add Layer.RuntimeClass, to make incremental adoption easier add Layer.toRunner, to make incremental adoption easier Mar 7, 2024
@tim-smart tim-smart marked this pull request as draft March 7, 2024 05:04
@tim-smart tim-smart marked this pull request as ready for review March 7, 2024 06:30
@tim-smart tim-smart changed the title add Layer.toRunner, to make incremental adoption easier add ManagedRuntime module, to make incremental adoption easier Mar 7, 2024
@tim-smart tim-smart merged commit 20e63fb into main Mar 11, 2024
12 checks passed
@tim-smart tim-smart deleted the runtime-class branch March 11, 2024 03:49
@github-actions github-actions bot mentioned this pull request Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants