Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow duration inputs to be singular #2263

Merged
merged 1 commit into from
Mar 8, 2024

Conversation

thewilkybarkid
Copy link
Contributor

Type

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

Add support for durations like '1 hour', rather than having to write '1 hours'. (There's deliberately no grammar checking, so '1 hours' is still supported, as is '2 hour'.)

Related

  • Related Issue #
  • Closes #

Copy link

changeset-bot bot commented Mar 8, 2024

🦋 Changeset detected

Latest commit: 1214e06

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 15 packages
Name Type
effect Patch
@effect/cli Patch
@effect/experimental Patch
@effect/opentelemetry Patch
@effect/platform-browser Patch
@effect/platform-bun Patch
@effect/platform-node-shared Patch
@effect/platform-node Patch
@effect/platform Patch
@effect/printer-ansi Patch
@effect/printer Patch
@effect/rpc-http Patch
@effect/rpc Patch
@effect/schema Patch
@effect/typeclass Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@tim-smart
Copy link
Member

Thanks!

@tim-smart tim-smart merged commit 507ba40 into Effect-TS:main Mar 8, 2024
12 checks passed
@github-actions github-actions bot mentioned this pull request Mar 8, 2024
@thewilkybarkid thewilkybarkid deleted the duration-input-singular branch March 8, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants