Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added support for PromiseLike #2280

Merged
merged 3 commits into from
Mar 13, 2024

Conversation

jessekelly881
Copy link
Contributor

@jessekelly881 jessekelly881 commented Mar 11, 2024

Extends Promise apis to use PromiseLike instead.

[pull] main from Effect-TS:main
Copy link

changeset-bot bot commented Mar 11, 2024

🦋 Changeset detected

Latest commit: 1b02b43

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 15 packages
Name Type
effect Patch
@effect/cli Patch
@effect/experimental Patch
@effect/opentelemetry Patch
@effect/platform-browser Patch
@effect/platform-bun Patch
@effect/platform-node-shared Patch
@effect/platform-node Patch
@effect/platform Patch
@effect/printer-ansi Patch
@effect/printer Patch
@effect/rpc-http Patch
@effect/rpc Patch
@effect/schema Patch
@effect/typeclass Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mikearnaldi
Copy link
Member

What's the point of resolve, can't we simply call then? also please don't use Merge Commits, it is safer to rebase the branch

@jessekelly881
Copy link
Contributor Author

jessekelly881 commented Mar 12, 2024

Yeah, you're right. We could replace .then, .catch with .then(onFulfilled, onRejected). I updated it.

Copy link
Member

@tim-smart tim-smart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@tim-smart tim-smart merged commit 802674b into Effect-TS:main Mar 13, 2024
12 checks passed
@github-actions github-actions bot mentioned this pull request Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants