Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add force option to FileSystem.remove #2427

Merged

Conversation

devmatteini
Copy link
Contributor

Type

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

Add force option to FileSystem.remove.

I didn't add any new tests, as this is an existing option of node fs rm.

I also moved the JSDocs into RemoveOptions type which should be more accurate than before on the remove function.

Let me know if I need to change anything!

Related

  • Related Issue #
  • Closes #

Copy link

changeset-bot bot commented Mar 27, 2024

🦋 Changeset detected

Latest commit: 85529ec

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
@effect/platform-node-shared Patch
@effect/platform Patch
@effect/platform-bun Patch
@effect/platform-node Patch
@effect/cli Patch
@effect/experimental Patch
@effect/platform-browser Patch
@effect/rpc-http Patch
@effect/rpc Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@tim-smart
Copy link
Member

It seems deno doesn't have a force option in their api, but I think we can work around that when we begin work on the deno platform package.

@tim-smart tim-smart merged commit 9c6a500 into Effect-TS:main Apr 2, 2024
12 checks passed
@github-actions github-actions bot mentioned this pull request Apr 2, 2024
@devmatteini devmatteini deleted the platform-file-system-remove-force branch April 2, 2024 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants