Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opentelemetry: export an empty NodeSDK layer #2433

Merged
merged 2 commits into from
Apr 2, 2024

Conversation

vecerek
Copy link
Contributor

@vecerek vecerek commented Mar 29, 2024

Type

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

Exposes a NodeSdk.empty layer for incremental adoption and unit testing purposes.

Related

@vecerek vecerek requested a review from tim-smart as a code owner March 29, 2024 07:14
Copy link

changeset-bot bot commented Mar 29, 2024

🦋 Changeset detected

Latest commit: 77f6428

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@effect/opentelemetry Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

packages/opentelemetry/src/NodeSdk.ts Outdated Show resolved Hide resolved
packages/opentelemetry/src/Resource.ts Outdated Show resolved Hide resolved
@vecerek vecerek requested a review from tim-smart April 2, 2024 06:21
Co-authored-by: Tim <hello@timsmart.co>
@tim-smart tim-smart merged commit ee10a50 into Effect-TS:main Apr 2, 2024
12 checks passed
@github-actions github-actions bot mentioned this pull request Apr 2, 2024
@vecerek vecerek deleted the node-sdk-empty-layer branch April 2, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Expose an empty NodeSDK layer
2 participants