Update @opentelemetry/* peer dependencies to ensure allowed versions include used imports
#2572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- lock pnpm to an exact hash of its version using `corepack use pnpm@<semver-tag>` - call `corepack pnpm` instead of `pnpm` in `pnpm` scripts, fixing `sh: pnpm: command not found`
…s include used imports Specifically, `Resource.ts` contains imports from `@opentelemetry/semantic-resources` that are not present in that package until version `1.22`
🦋 Changeset detectedLatest commit: 202569a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
fubhy
previously requested changes
Apr 19, 2024
This reverts commit be121c9.
5 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type
Description
The main thing is updating
@opentelemetry/*peer dependencies to ensure the allowed version range includes imports used in@effect/opentelemetry.Specifically,
Resource.tsin@effect/opentelemetrycontains imports from@opentelemetry/semantic-resourcesthat are not present in that package until version1.22.