Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add SpanKind to Tracer spans #2597

Merged
merged 8 commits into from
Apr 23, 2024
Merged

add SpanKind to Tracer spans #2597

merged 8 commits into from
Apr 23, 2024

Conversation

patroza
Copy link
Member

@patroza patroza commented Apr 22, 2024

No description provided.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 22, 2024 •
edited

🦋 Changeset detected

Latest commit: 44c230d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 24 packages
Name Type
@effect/opentelemetry Major
effect Minor
@effect/experimental Major
@effect/platform Major
@effect/rpc Major
@effect/sql Major
@effect/cli Major
@effect/platform-browser Major
@effect/platform-bun Major
@effect/platform-node-shared Major
@effect/platform-node Major
@effect/printer-ansi Major
@effect/printer Major
@effect/rpc-http Major
@effect/schema Major
@effect/sql-mssql Major
@effect/sql-mysql2 Major
@effect/sql-pg Major
@effect/sql-sqlite-bun Major
@effect/sql-sqlite-node Major
@effect/sql-sqlite-react-native Major
@effect/sql-sqlite-wasm Major
@effect/typeclass Major
@effect/vitest Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@patroza patroza marked this pull request as draft April 22, 2024 14:58
@patroza patroza marked this pull request as ready for review April 22, 2024 16:36
tim-smart
tim-smart requested changes Apr 22, 2024
View reviewed changes
.changeset/healthy-lamps-stare.md Outdated Show resolved Hide resolved
packages/effect/src/Tracer.ts Outdated Show resolved Hide resolved
packages/effect/src/Tracer.ts Outdated Show resolved Hide resolved
packages/effect/src/Tracer.ts Outdated Show resolved Hide resolved
packages/platform/src/internal/http/client.ts Outdated Show resolved Hide resolved
@github-actions github-actions bot changed the base branch from main to next-minor April 22, 2024 21:48
tim-smart
tim-smart requested changes Apr 22, 2024
View reviewed changes
packages/experimental/src/DevTools/Client.ts Outdated Show resolved Hide resolved
packages/opentelemetry/src/internal/tracer.ts Outdated Show resolved Hide resolved
packages/effect/src/internal/tracer.ts Outdated Show resolved Hide resolved
@tim-smart tim-smart changed the title fix: Use Otel SpanKind add SpanKind to Tracer spans Apr 23, 2024
@tim-smart tim-smart merged commit 0deee4b into next-minor Apr 23, 2024
12 checks passed
@tim-smart tim-smart deleted the f/otel/spankind branch April 23, 2024 03:19
@github-actions github-actions bot mentioned this pull request Apr 23, 2024
Merged
github-actions bot pushed a commit that referenced this pull request Apr 24, 2024
@patroza @tim-smart @mikearnaldi
add SpanKind to Tracer spans (#2597)
b36981e 
Co-authored-by: Tim <hello@timsmart.co>
github-actions bot pushed a commit that referenced this pull request Apr 24, 2024
@patroza @tim-smart @mikearnaldi
add SpanKind to Tracer spans (#2597)
b48afb6 
Co-authored-by: Tim <hello@timsmart.co>
patroza added a commit to patroza/effect that referenced this pull request Apr 24, 2024
@patroza @tim-smart
add SpanKind to Tracer spans (Effect-TS#2597)
1c15173 
Co-authored-by: Tim <hello@timsmart.co>
github-actions bot pushed a commit that referenced this pull request Apr 25, 2024
@patroza @tim-smart
add SpanKind to Tracer spans (#2597)
2c90a2d 
Co-authored-by: Tim <hello@timsmart.co>
github-actions bot pushed a commit that referenced this pull request Apr 25, 2024
@patroza @tim-smart
add SpanKind to Tracer spans (#2597)
943cb11 
Co-authored-by: Tim <hello@timsmart.co>
github-actions bot pushed a commit that referenced this pull request Apr 25, 2024
@patroza @tim-smart
add SpanKind to Tracer spans (#2597)
2cdf9b8 
Co-authored-by: Tim <hello@timsmart.co>
patroza added a commit to patroza/effect that referenced this pull request Apr 25, 2024
@patroza @tim-smart
add SpanKind to Tracer spans (Effect-TS#2597)
535899b 
Co-authored-by: Tim <hello@timsmart.co>
github-actions bot pushed a commit that referenced this pull request Apr 25, 2024
@patroza @tim-smart @fubhy
add SpanKind to Tracer spans (#2597)
6935cd5 
Co-authored-by: Tim <hello@timsmart.co>
github-actions bot pushed a commit that referenced this pull request Apr 25, 2024
@patroza @tim-smart @mikearnaldi
add SpanKind to Tracer spans (#2597)
ce0ec5c 
Co-authored-by: Tim <hello@timsmart.co>
tim-smart added a commit that referenced this pull request Apr 26, 2024
@patroza @tim-smart
add SpanKind to Tracer spans (#2597)
7447623 
Co-authored-by: Tim <hello@timsmart.co>
github-actions bot pushed a commit that referenced this pull request Apr 26, 2024
@patroza @tim-smart
add SpanKind to Tracer spans (#2597)
d32412f 
Co-authored-by: Tim <hello@timsmart.co>
github-actions bot pushed a commit that referenced this pull request Apr 26, 2024
@patroza @tim-smart @mikearnaldi
add SpanKind to Tracer spans (#2597)
4b45a9b 
Co-authored-by: Tim <hello@timsmart.co>
github-actions bot pushed a commit that referenced this pull request Apr 26, 2024
@patroza @tim-smart @mikearnaldi
add SpanKind to Tracer spans (#2597)
754f857 
Co-authored-by: Tim <hello@timsmart.co>
github-actions bot pushed a commit that referenced this pull request Apr 26, 2024
@patroza @tim-smart @gcanti
add SpanKind to Tracer spans (#2597)
1b7390f 
Co-authored-by: Tim <hello@timsmart.co>
github-actions bot pushed a commit that referenced this pull request Apr 26, 2024
@patroza @tim-smart
add SpanKind to Tracer spans (#2597)
a10c34e 
Co-authored-by: Tim <hello@timsmart.co>
github-actions bot pushed a commit that referenced this pull request Apr 27, 2024
@patroza @tim-smart @mikearnaldi
add SpanKind to Tracer spans (#2597)
c56b4ed 
Co-authored-by: Tim <hello@timsmart.co>
github-actions bot pushed a commit that referenced this pull request Apr 27, 2024
@patroza @tim-smart @mikearnaldi
add SpanKind to Tracer spans (#2597)
11dc85c 
Co-authored-by: Tim <hello@timsmart.co>
github-actions bot pushed a commit that referenced this pull request Apr 27, 2024
@patroza @tim-smart @mikearnaldi
add SpanKind to Tracer spans (#2597)
33fcc0d 
Co-authored-by: Tim <hello@timsmart.co>
github-actions bot pushed a commit that referenced this pull request Apr 28, 2024
@patroza @tim-smart
add SpanKind to Tracer spans (#2597)
8b88159 
Co-authored-by: Tim <hello@timsmart.co>
github-actions bot pushed a commit that referenced this pull request Apr 28, 2024
@patroza @tim-smart
add SpanKind to Tracer spans (#2597)
40593da 
Co-authored-by: Tim <hello@timsmart.co>
github-actions bot pushed a commit that referenced this pull request Apr 29, 2024
@patroza @tim-smart @mikearnaldi
add SpanKind to Tracer spans (#2597)
b76c2e5 
Co-authored-by: Tim <hello@timsmart.co>
github-actions bot pushed a commit that referenced this pull request Apr 29, 2024
@patroza @tim-smart @mikearnaldi
add SpanKind to Tracer spans (#2597)
0160807 
Co-authored-by: Tim <hello@timsmart.co>
github-actions bot pushed a commit that referenced this pull request Apr 29, 2024
@patroza @tim-smart
add SpanKind to Tracer spans (#2597)
4861a19 
Co-authored-by: Tim <hello@timsmart.co>
github-actions bot pushed a commit that referenced this pull request Apr 29, 2024
@patroza @tim-smart
add SpanKind to Tracer spans (#2597)
ff832bd 
Co-authored-by: Tim <hello@timsmart.co>
github-actions bot pushed a commit that referenced this pull request Apr 29, 2024
@patroza @tim-smart
add SpanKind to Tracer spans (#2597)
b52d318 
Co-authored-by: Tim <hello@timsmart.co>
tim-smart added a commit that referenced this pull request Apr 30, 2024
@patroza @tim-smart
add SpanKind to Tracer spans (#2597)
a023f28 
Co-authored-by: Tim <hello@timsmart.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tim-smart tim-smart tim-smart approved these changes

@mikearnaldi mikearnaldi Awaiting requested review from mikearnaldi mikearnaldi is a code owner

Assignees
No one assigned
Labels
next-minor
Projects
PR Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@patroza @tim-smart