Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow use of Effect.gen without the adapter #2602

Merged
merged 17 commits into from
Apr 24, 2024
Merged

Conversation

mikearnaldi
Copy link
Member

No description provided.

Copy link

changeset-bot bot commented Apr 24, 2024

🦋 Changeset detected

Latest commit: a4b979f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 24 packages
Name Type
effect Patch
@effect/cli Patch
@effect/experimental Patch
@effect/opentelemetry Patch
@effect/platform-browser Patch
@effect/platform-bun Patch
@effect/platform-node-shared Patch
@effect/platform-node Patch
@effect/platform Patch
@effect/printer-ansi Patch
@effect/printer Patch
@effect/rpc-http Patch
@effect/rpc Patch
@effect/schema Patch
@effect/sql-mssql Patch
@effect/sql-mysql2 Patch
@effect/sql-pg Patch
@effect/sql-sqlite-bun Patch
@effect/sql-sqlite-node Patch
@effect/sql-sqlite-react-native Patch
@effect/sql-sqlite-wasm Patch
@effect/sql Patch
@effect/typeclass Patch
@effect/vitest Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mikearnaldi
Copy link
Member Author

interface EffectGenerator<Eff extends Effect<any, any, any>> {
  next(): IteratorResult<Eff, Effect.Success<Eff>>
  return(value: Effect.Success<Eff>): IteratorResult<Eff, Effect.Success<Eff>>
  throw(e: any): IteratorResult<Eff, Effect.Success<Eff>>
  [Symbol.iterator](): EffectGenerator<Eff>
}

This is nuts but it may actually work...

@tim-smart tim-smart force-pushed the repro/variance-generator branch 2 times, most recently from 1233e35 to 71eb3e1 Compare April 24, 2024 09:11
@tim-smart tim-smart changed the title Repro for variance change allow use of Effect.gen without the adapter Apr 24, 2024
@tim-smart tim-smart marked this pull request as ready for review April 24, 2024 09:12
@mikearnaldi mikearnaldi merged commit 9a24667 into main Apr 24, 2024
12 checks passed
@mikearnaldi mikearnaldi deleted the repro/variance-generator branch April 24, 2024 14:34
@github-actions github-actions bot mentioned this pull request Apr 22, 2024
@mikearnaldi
Copy link
Member Author

/snapshot

Copy link
Contributor

github-actions bot commented Apr 24, 2024

Sorry @mikearnaldi, I failed to publish the snapshot!

You can review the build log here.

@enricopolanski
Copy link

What a massive, massive PR. Kudos.

@fubhy
Copy link
Member

fubhy commented Apr 24, 2024

/snapshot

Branch was already deleted here. Either need to do that in the Version Packages PR (after merge) or do it here before merging :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

5 participants