Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Option.liftPredicate dual #2957

Merged
merged 4 commits into from
Jun 12, 2024
Merged

Make Option.liftPredicate dual #2957

merged 4 commits into from
Jun 12, 2024

Conversation

LaureRC
Copy link
Contributor

@LaureRC LaureRC commented Jun 8, 2024

Type

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

Make Option.liftPredicate dual to be able to use a data-first version when wanted

Related

N/A

@LaureRC LaureRC requested a review from mikearnaldi as a code owner June 8, 2024 15:04
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jun 8, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 3f853a3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 25 packages
Name Type
effect Minor
@effect/cli Major
@effect/experimental Major
@effect/opentelemetry Major
@effect/platform-browser Major
@effect/platform-bun Major
@effect/platform-node-shared Major
@effect/platform-node Major
@effect/platform Major
@effect/printer-ansi Major
@effect/printer Major
@effect/rpc-http Major
@effect/rpc Major
@effect/schema Major
@effect/sql-drizzle Major
@effect/sql-mssql Major
@effect/sql-mysql2 Major
@effect/sql-pg Major
@effect/sql-sqlite-bun Major
@effect/sql-sqlite-node Major
@effect/sql-sqlite-react-native Major
@effect/sql-sqlite-wasm Major
@effect/sql Major
@effect/typeclass Major
@effect/vitest Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

tim-smart
tim-smart requested changes Jun 9, 2024
View reviewed changes
.changeset/fair-turkeys-float.md Outdated Show resolved Hide resolved
@github-actions github-actions bot changed the base branch from main to next-minor June 10, 2024 06:20
@LaureRC LaureRC requested a review from tim-smart June 10, 2024 06:21
@github-actions github-actions bot force-pushed the next-minor branch 5 times, most recently from b6ce3f9 to 3572b58 Compare June 11, 2024 08:03
@github-actions github-actions bot force-pushed the make-option-liftpredicate-dual branch from acf8265 to 10e3924 Compare June 11, 2024 09:03
@github-actions github-actions bot force-pushed the make-option-liftpredicate-dual branch from 10e3924 to 3f853a3 Compare June 12, 2024 01:01
@tim-smart tim-smart merged commit f51ab48 into Effect-TS:next-minor Jun 12, 2024
@github-actions github-actions bot mentioned this pull request Jun 12, 2024
Merged
github-actions bot pushed a commit that referenced this pull request Jun 12, 2024
@LaureRC @mikearnaldi
Make Option.liftPredicate dual (#2957)
31a5555
github-actions bot pushed a commit that referenced this pull request Jun 12, 2024
@LaureRC @gcanti
Make Option.liftPredicate dual (#2957)
5ec3fa4
github-actions bot pushed a commit that referenced this pull request Jun 13, 2024
@LaureRC @gcanti
Make Option.liftPredicate dual (#2957)
a48c616
github-actions bot pushed a commit to dilame/effect that referenced this pull request Jun 14, 2024
@LaureRC @gcanti
Make Option.liftPredicate dual (Effect-TS#2957)
fe5e331
github-actions bot pushed a commit that referenced this pull request Jun 14, 2024
@LaureRC @tim-smart
Make Option.liftPredicate dual (#2957)
d9d043e
github-actions bot pushed a commit that referenced this pull request Jun 14, 2024
@LaureRC @gcanti
Make Option.liftPredicate dual (#2957)
2bdd713
github-actions bot pushed a commit that referenced this pull request Jun 14, 2024
@LaureRC @gcanti
Make Option.liftPredicate dual (#2957)
79921c0
github-actions bot pushed a commit that referenced this pull request Jun 15, 2024
@LaureRC @gcanti
Make Option.liftPredicate dual (#2957)
cef64e0
github-actions bot pushed a commit that referenced this pull request Jun 16, 2024
@LaureRC @gcanti
Make Option.liftPredicate dual (#2957)
ba988b3
github-actions bot pushed a commit that referenced this pull request Jun 16, 2024
@LaureRC @gcanti
Make Option.liftPredicate dual (#2957)
392ce20
github-actions bot pushed a commit that referenced this pull request Jun 16, 2024
@LaureRC @gcanti
Make Option.liftPredicate dual (#2957)
9c0c9d8
github-actions bot pushed a commit that referenced this pull request Jun 17, 2024
@LaureRC @tim-smart
Make Option.liftPredicate dual (#2957)
2071a47
github-actions bot pushed a commit that referenced this pull request Jun 17, 2024
@LaureRC @tim-smart
Make Option.liftPredicate dual (#2957)
4957f2d
github-actions bot pushed a commit that referenced this pull request Jun 17, 2024
@LaureRC @tim-smart
Make Option.liftPredicate dual (#2957)
b9963fc
github-actions bot pushed a commit that referenced this pull request Jun 17, 2024
@LaureRC @mikearnaldi
Make Option.liftPredicate dual (#2957)
a218471
github-actions bot pushed a commit that referenced this pull request Jun 17, 2024
@LaureRC @gcanti
Make Option.liftPredicate dual (#2957)
b58f2b6
github-actions bot pushed a commit that referenced this pull request Jun 17, 2024
@LaureRC @gcanti
Make Option.liftPredicate dual (#2957)
b0ee843
github-actions bot pushed a commit that referenced this pull request Jun 18, 2024
@LaureRC @gcanti
Make Option.liftPredicate dual (#2957)
d4e8896
github-actions bot pushed a commit that referenced this pull request Jun 18, 2024
@LaureRC @gcanti
Make Option.liftPredicate dual (#2957)
c600b11
github-actions bot pushed a commit that referenced this pull request Jun 18, 2024
@LaureRC @gcanti
Make Option.liftPredicate dual (#2957)
519af55
github-actions bot pushed a commit that referenced this pull request Jun 18, 2024
@LaureRC @tim-smart
Make Option.liftPredicate dual (#2957)
ae94dfe
github-actions bot pushed a commit that referenced this pull request Jun 19, 2024
@LaureRC @gcanti
Make Option.liftPredicate dual (#2957)
3c1efb5
github-actions bot pushed a commit that referenced this pull request Jun 19, 2024
@LaureRC @gcanti
Make Option.liftPredicate dual (#2957)
f84269b
github-actions bot pushed a commit that referenced this pull request Jun 19, 2024
@LaureRC @gcanti
Make Option.liftPredicate dual (#2957)
f182d22
github-actions bot pushed a commit that referenced this pull request Jun 20, 2024
@LaureRC @tim-smart
Make Option.liftPredicate dual (#2957)
d37aa26
github-actions bot pushed a commit that referenced this pull request Jun 20, 2024
@LaureRC @tim-smart
Make Option.liftPredicate dual (#2957)
7fb15fe
github-actions bot pushed a commit that referenced this pull request Jun 20, 2024
@LaureRC @gcanti
Make Option.liftPredicate dual (#2957)
4bb9610
github-actions bot pushed a commit that referenced this pull request Jun 20, 2024
@LaureRC @IMax153
Make Option.liftPredicate dual (#2957)
8425d6f
github-actions bot pushed a commit that referenced this pull request Jun 20, 2024
@LaureRC @gcanti
Make Option.liftPredicate dual (#2957)
5ceb9c3
github-actions bot pushed a commit that referenced this pull request Jun 20, 2024
@LaureRC @gcanti
Make Option.liftPredicate dual (#2957)
f222442
github-actions bot pushed a commit that referenced this pull request Jun 20, 2024
@LaureRC @gcanti
Make Option.liftPredicate dual (#2957)
bdc5903
github-actions bot pushed a commit that referenced this pull request Jun 20, 2024
@LaureRC @gcanti
Make Option.liftPredicate dual (#2957)
23d9265
github-actions bot pushed a commit that referenced this pull request Jun 20, 2024
@LaureRC @gcanti
Make Option.liftPredicate dual (#2957)
100ac68
github-actions bot pushed a commit that referenced this pull request Jun 20, 2024
@LaureRC @tim-smart
Make Option.liftPredicate dual (#2957)
5315819
github-actions bot pushed a commit that referenced this pull request Jun 20, 2024
@LaureRC @tim-smart
Make Option.liftPredicate dual (#2957)
8681ccc
tim-smart pushed a commit that referenced this pull request Jun 20, 2024
@LaureRC @tim-smart
Make Option.liftPredicate dual (#2957)
c0ce180
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tim-smart tim-smart tim-smart approved these changes

@mikearnaldi mikearnaldi Awaiting requested review from mikearnaldi mikearnaldi is a code owner

Assignees
No one assigned
Labels
next-minor
Projects
PR Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@LaureRC @tim-smart