Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

homework-4 #4

Merged
merged 169 commits into from
May 4, 2024
Merged

homework-4 #4

merged 169 commits into from
May 4, 2024

Conversation

Efler
Copy link
Owner

@Efler Efler commented Mar 7, 2024

No description provided.

@Efler Efler self-assigned this Mar 7, 2024
@Efler
Copy link
Owner Author

Efler commented Mar 10, 2024

Code Coverage

Overall Project 41.78% -52.51% 🍏
Files changed 42.08% 🍏

File Coverage
LinkUpdateScheduler.java 100% 🍏
ChatDao.java 100% 🍏
TrackingDao.java 100% 🍏
JpaLinkService.java 100% 🍏
StackoverflowClient.java 94.7% -5.3% 🍏
LinkDao.java 91.54% -8.46% 🍏
JpaTgChatService.java 83.48% -16.52% 🍏
BranchDao.java 83.26% -16.74% 🍏
GithubClient.java 75.12% -24.88% 🍏
JpaLinkUpdateService.java 58.76% -41.24% 🍏
ScrapperApplication.java 37.5% 🍏
TgChatController.java 27.27% -72.73%
BotClient.java 19.09% -54.55%
SecurityService.java 16.67% -83.33%
LinksController.java 5.83% -80.58%
RestExceptionHandler.java 1.35% 🍏
ScrapperQueueProducer.java 0%
JdbcLinkService.java 0%
JdbcLinkUpdateService.java 0%
JdbcTgChatService.java 0%
JooqTgChatService.java 0%
JooqLinkUpdateService.java 0%
JooqLinkService.java 0%

);
liquibase.update(new Contexts(), new LabelExpression());

connection.close();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Не обязательно вызывать close явно.

Вроде как Connection имплементирует интерфейс AutoCloseable, и джава сама разберется

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Хорошо!

@Efler Efler merged commit f2dd5ab into homework-3 May 4, 2024
6 checks passed
@Efler Efler deleted the homework-4 branch May 4, 2024 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants