Start moving to {httr2} #18
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Using attachment::att_amend_desc()
- After devtools::check()
- auto check on GitHub Actions - auto pkgdown website on GitHub (Eflores89#16)
httr is not maintained anymore - This commit changes getNotionDatabase() to use httr2 Note that I cannot send a query with a NULL inside, hence the trick with page_size to always get a non empty list in "data"
- For better follow-up on installations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Package {httr} is not maintained any more. We now need to use {httr2} in replacement.
This requires many changes in your package.
In this PR, I start with one function changed:
getNotionDatabase()The syntax required some adjustments.
I let you decide if you want to include these changes now.
At some point, if you want to continue the integration of httr2, it may be good to add some unit tests applied on an example Notion Workspace created for the purpose.
Important note : If you accept this PR, there is no need to accept my other PR #17 , as the present one includes changes of the other. You can also accept them one at a time, there should not be conflicts.