Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upAdded a message over the update of the module #24
Conversation
EggieCode
requested a review
from
cryptofuture
Aug 9, 2017
This comment has been minimized.
This comment has been minimized.
|
Thats fine, but maybe it worth to remove you need to be root message, and use sudo instead. We on Ubuntu after all, sudo is default. |
This comment has been minimized.
This comment has been minimized.
|
Done! |
cryptofuture
reviewed
Aug 9, 2017
debian/wireguard-dkms.postinst
Outdated
| @@ -25,8 +25,8 @@ case "$1" in | |||
| echo "new version, you will need to remove the old module and load the new one. As" | |||
This comment has been minimized.
This comment has been minimized.
cryptofuture
Aug 9, 2017
Collaborator
echo "new version, you will need to remove the old module and load the new one."
echo "You can accomplish this with the following commands:"
zx2c4
reviewed
Aug 9, 2017
debian/wireguard-dkms.postinst
Outdated
| configure) | ||
| # Check if the wireguard module is loaded else the install will fail. | ||
| if [ ! -f "/sys/module/wireguard/version" ]; then | ||
| echo "WARNING: kernel module is not loaded" |
This comment has been minimized.
This comment has been minimized.
zx2c4
Aug 9, 2017
Contributor
You don't need this WARNING, since the kernel module is loaded ondemand.
However, you do need the exit 0 below, so keep that.
This comment has been minimized.
This comment has been minimized.
|
Tonight I will update to version |
EggieCode
merged commit ccefc3c
into
master
Aug 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
EggieCode commentedAug 9, 2017
A update for wireguard-dkms to message you need to
rmmod wireguard && modprobe wireguardfor enabling the new version.Ping: @zx2c4 , @cryptofuture