Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VSIX ships a lot of unrelated files, including Roslyn #22

Open
Therzok opened this issue Feb 28, 2021 · 4 comments
Open

VSIX ships a lot of unrelated files, including Roslyn #22

Therzok opened this issue Feb 28, 2021 · 4 comments

Comments

@Therzok
Copy link

Therzok commented Feb 28, 2021

It should just reference dlls and allow the roslyn host to load them. Right now, the extension (along with some others) cause my VS to not show quick info. :D

@EgorBo
Copy link
Owner

EgorBo commented Feb 28, 2021

@Therzok ah yeah, something definitely went wrong here 🙂
Initially the addin was based on the LightBulb sample from https://github.com/microsoft/VSSDK-Extensibility-Samples/tree/master/LightBulb (it's pretty out of date)

trying to figure out how to optimize it.

@EgorBo
Copy link
Owner

EgorBo commented Feb 28, 2021

hm.. looks like most of it comes with "Microsoft.CodeAnalysis.EditorFeatures.Text" nuget package which is only needed for GetRelatedDocuments() API

@Therzok
Copy link
Author

Therzok commented Feb 28, 2021

You can most likely ship the vsix without bundling Roslyn, but by having a dependyencu on the .net sdk extension

@Therzok
Copy link
Author

Therzok commented Feb 28, 2021

The assemblies exist in the appdomain, and the host will redirect you to the version it uses. Basically, all the imported packagereference that already exist in VS have to not be locally copied.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants