Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add many features of clash #651

Merged
merged 5 commits into from Mar 19, 2022
Merged

feat: add many features of clash #651

merged 5 commits into from Mar 19, 2022

Conversation

Ehco1996
Copy link
Owner

close #643 #644

@sourcery-ai
Copy link

sourcery-ai bot commented Mar 19, 2022

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.43%.

Quality metrics Before After Change
Complexity 2.24 ⭐ 2.15 ⭐ -0.09 👍
Method Length 34.83 ⭐ 34.42 ⭐ -0.41 👍
Working memory 6.28 🙂 6.21 🙂 -0.07 👍
Quality 82.36% 82.79% 0.43% 👍
Other metrics Before After Change
Lines 969 996 27
Changed files Quality Before Quality After Quality Change
apps/sub.py 71.53% 🙂 74.79% 🙂 3.26% 👍
apps/api/urls.py 76.93% ⭐ 75.88% ⭐ -1.05% 👎
apps/api/views.py 83.69% ⭐ 83.39% ⭐ -0.30% 👎
apps/sspanel/models.py 84.28% ⭐ 84.28% ⭐ 0.00%
apps/sspanel/management/commands/create_admin.py 68.21% 🙂 67.78% 🙂 -0.43% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
apps/sspanel/models.py Goods.purchase_by_user 7 ⭐ 146 😞 10 😞 56.45% 🙂 Try splitting into smaller methods. Extract out complex expressions
apps/sspanel/models.py UserOrder.get_or_create_order 2 ⭐ 97 🙂 13 😞 62.22% 🙂 Extract out complex expressions
apps/sspanel/management/commands/create_admin.py Command.handle 4 ⭐ 114 🙂 10 😞 63.16% 🙂 Extract out complex expressions
apps/sspanel/models.py UserOrder.get_success_order_amount 1 ⭐ 36 ⭐ 10 😞 77.76% ⭐ Extract out complex expressions
apps/sspanel/models.py User.get_subinfo_header 0 ⭐ 37 ⭐ 10 😞 78.59% ⭐ Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@Ehco1996 Ehco1996 changed the title add many features of clash feat: add many features of clash Mar 19, 2022
@Ehco1996 Ehco1996 merged commit ba3d9d0 into dev Mar 19, 2022
@Ehco1996 Ehco1996 deleted the feature-proxy-group branch March 19, 2022 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support clash proxy provider
1 participant