Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: subscribe return filename #734

Merged
merged 1 commit into from Oct 11, 2022
Merged

feat: subscribe return filename #734

merged 1 commit into from Oct 11, 2022

Conversation

sljeff
Copy link
Collaborator

@sljeff sljeff commented Oct 11, 2022

image

@sourcery-ai
Copy link

sourcery-ai bot commented Oct 11, 2022

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.05%.

Quality metrics Before After Change
Complexity 1.62 ⭐ 1.61 ⭐ -0.01 👍
Method Length 40.29 ⭐ 40.50 ⭐ 0.21 👎
Working memory 5.74 ⭐ 5.75 ⭐ 0.01 👎
Quality 83.16% 83.11% -0.05% 👎
Other metrics Before After Change
Lines 604 610 6
Changed files Quality Before Quality After Quality Change
apps/sspanel/models.py 83.16% ⭐ 83.11% ⭐ -0.05% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
apps/sspanel/models.py Goods.purchase_by_user 7 ⭐ 189 😞 9 🙂 54.43% 🙂 Try splitting into smaller methods
apps/sspanel/models.py UserOrder.get_or_create_order 2 ⭐ 130 😞 9 🙂 65.23% 🙂 Try splitting into smaller methods
apps/sspanel/models.py User.get_subinfo_header 0 ⭐ 59 ⭐ 10 😞 75.06% ⭐ Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

apps/sspanel/models.py Outdated Show resolved Hide resolved
Copy link
Owner

@Ehco1996 Ehco1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM nice job

@Ehco1996 Ehco1996 merged commit 7f5f97e into Ehco1996:dev Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants