fix: wrong space in attachment (Sourcery refactored) #738
Conversation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
| port_set = {i for i in range(cls.MIN_PORT, max_port + 1)}.difference( | ||
| port_set = set(range(cls.MIN_PORT, max_port + 1)).difference( | ||
| port_set.union(cls.PORT_BLACK_SET) | ||
| ) | ||
|
|
There was a problem hiding this comment.
Function User.get_not_used_port refactored with the following changes:
- Replace identity comprehension with call to collection constructor (
identity-comprehension)
| return settings.HOST + f"/api/subscribe/?{urlencode(params)}" | ||
| return f"{settings.HOST}/api/subscribe/?{urlencode(params)}" |
There was a problem hiding this comment.
Function User.sub_link refactored with the following changes:
- Use f-string instead of string concatenation (
use-fstring-for-concatenation)
| return settings.HOST + f"/register/?{urlencode(params)}" | ||
| return f"{settings.HOST}/register/?{urlencode(params)}" |
There was a problem hiding this comment.
Function User.ref_link refactored with the following changes:
- Use f-string instead of string concatenation (
use-fstring-for-concatenation)
| return ( | ||
| settings.HOST + f"/api/subscribe/clash/proxy_providers/?{urlencode(params)}" | ||
| ) | ||
| return f"{settings.HOST}/api/subscribe/clash/proxy_providers/?{urlencode(params)}" |
There was a problem hiding this comment.
Function User.clash_proxy_provider_endpoint refactored with the following changes:
- Use f-string instead of string concatenation (
use-fstring-for-concatenation)
| changed = order.check_order_status() | ||
| if changed: | ||
| if changed := order.check_order_status(): |
There was a problem hiding this comment.
Function UserOrder.make_up_lost_orders refactored with the following changes:
- Use named expression to simplify assignment and conditional (
use-named-expression)
| return "{}-{}".format(self.user, self.money) | ||
| return f"{self.user}-{self.money}" |
There was a problem hiding this comment.
Function Donate.__str__ refactored with the following changes:
- Replace call to format with f-string (
use-fstring-for-formatting)
| self.code = "{}{}".format(self.code, get_long_random_string()) | ||
| self.code = f"{self.code}{get_long_random_string()}" |
There was a problem hiding this comment.
Function MoneyCode.clean refactored with the following changes:
- Replace call to format with f-string (
use-fstring-for-formatting)
| if self.status == self.STATUS_ON: | ||
| return "上架" | ||
| else: | ||
| return "下架" | ||
| return "上架" if self.status == self.STATUS_ON else "下架" |
There was a problem hiding this comment.
Function Goods.status_cn refactored with the following changes:
- Replace if statement with if expression (
assign-if-exp)
| "{} ~ {} 时间内 商品: {} 共销售 {} 次 总金额 {} 元".format( | ||
| start.date(), end.date(), good, count, amount | ||
| ) | ||
| f"{start.date()} ~ {end.date()} 时间内 商品: {good} 共销售 {count} 次 总金额 {amount} 元" |
There was a problem hiding this comment.
Function PurchaseHistory.cost_statistics refactored with the following changes:
- Replace call to format with f-string (
use-fstring-for-formatting)
| return "日期:{}".format(str(self.time)[:9]) | ||
| return f"日期:{str(self.time)[:9]}" |
There was a problem hiding this comment.
Function Announcement.__str__ refactored with the following changes:
- Replace call to format with f-string (
use-fstring-for-formatting)
Sourcery Code Quality Report❌ Merging this PR will decrease code quality in the affected files by 0.36%.
Here are some functions in these files that still need a tune-up:
Legend and ExplanationThe emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request. Please see our documentation here for details on how these metrics are calculated. We are actively working on this report - lots more documentation and extra metrics to come! Help us improve this quality report! |
Pull Request #737 refactored by Sourcery.
Since the original Pull Request was opened as a fork in a contributor's
repository, we are unable to create a Pull Request branching from it.
To incorporate these changes, you can either:
Merge this Pull Request instead of the original, or
Ask your contributor to locally incorporate these commits and push them to
the original Pull Request
Incorporate changes via command line
NOTE: As code is pushed to the original Pull Request, Sourcery will
re-run and update (force-push) this Pull Request with new refactorings as
necessary. If Sourcery finds no refactorings at any point, this Pull Request
will be closed automatically.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Help us improve this pull request!