Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⚙️ Implement config validation #40

Closed
roma-glushko opened this issue Dec 26, 2023 · 0 comments · Fixed by #98
Closed

⚙️ Implement config validation #40

roma-glushko opened this issue Dec 26, 2023 · 0 comments · Fixed by #98
Assignees
@roma-glushko
Labels
area:config size:small
Milestone
Glide: Private Pr...

Comments

@roma-glushko
Copy link
Member

No description provided.

@roma-glushko roma-glushko mentioned this issue Dec 26, 2023
Merged
@roma-glushko roma-glushko self-assigned this Jan 16, 2024
@roma-glushko roma-glushko changed the title Implement config validation ⚙️ Implement config validation Jan 21, 2024
@roma-glushko roma-glushko mentioned this issue Jan 21, 2024
Closed
roma-glushko added a commit that referenced this issue Jan 21, 2024
@roma-glushko
⚙️ #40: Added config validation
a49714f
roma-glushko added a commit that referenced this issue Jan 21, 2024
@roma-glushko
#40 Updated OpenAPI specs
feeb857
roma-glushko added a commit that referenced this issue Jan 21, 2024
@roma-glushko
#40: Covered the validation by tests
75b7fce
roma-glushko added a commit that referenced this issue Jan 21, 2024
@roma-glushko
#40 linting
3408439
roma-glushko added a commit that referenced this issue Jan 21, 2024
@roma-glushko
#40 Warn about too few models in a router pool & output more informat…
1452002 
…ion in logs like loaded config
roma-glushko added a commit that referenced this issue Jan 21, 2024
@roma-glushko
#40 Made sure there is at least one active model in a router
431bd96
roma-glushko added a commit that referenced this issue Jan 21, 2024
@roma-glushko
#40: Made sure it's not possible to duplicate router & model IDs
6213299
roma-glushko added a commit that referenced this issue Jan 21, 2024
@roma-glushko
#40: Updated OpenAPI spec
0f62a9c
@roma-glushko roma-glushko linked a pull request Jan 21, 2024 that will close this issue
⚙️ #40: Added config validation #98
Merged
roma-glushko added a commit that referenced this issue Jan 21, 2024
@roma-glushko
#40: Tested against the empty router setup
fe21efa
roma-glushko added a commit that referenced this issue Jan 21, 2024
@roma-glushko
#40 Tested router config validation
43041a7
roma-glushko added a commit that referenced this issue Jan 22, 2024
@roma-glushko
⚙️ #40: Added config validation (#98)
750fd9e 
- Made sure it's not possible to override the required fields by nil values accidentally by misformatting the config file
- used github.com/go-playground/validator/v10 for config validation
- created custom validation errors
- Made sure router and model IDs are unique
- Made sure there is at least one lang router configured
- Made sure that each router has at least one model configured
- Warn users in case there is only one model in the router's pool
@roma-glushko roma-glushko mentioned this issue Jan 22, 2024
Merged
roma-glushko added a commit that referenced this issue Jan 22, 2024
@roma-glushko
📦 Release: v0.0.1-rc.2 (#102)
2c8ca01 
# Changelog

## Improvements

- ⚙️ [config] Added validation for config file content #40 (@roma-glushko)
- ⚙️ [config] Allowed to pass HTTP server configs from config file #41 (@roma-glushko)
- 👷 [build] Allowed building Homebrew taps for release candidates #99 (@roma-glushko)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@roma-glushko roma-glushko

Labels
area:config size:small
Projects
None yet
Milestone
Glide: Private Preview (MVP)
Development

Successfully merging a pull request may close this issue.

⚙️ #40: Added config validation EinStack/glide
1 participant
@roma-glushko