Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ClimateType of 'wakeup' not found, halts further processing #46

Closed
danvanklaveren opened this issue Aug 29, 2019 · 7 comments
Closed

ClimateType of 'wakeup' not found, halts further processing #46

danvanklaveren opened this issue Aug 29, 2019 · 7 comments
Assignees
Milestone

Comments

@danvanklaveren
Copy link

danvanklaveren commented Aug 29, 2019

Not sure if this is a recent change from Ecobee
From the log:
2019-08-29 11:30:38,817 [Controller] [DEBUG] EcobeeF_########:t######:Ecobee - Upstairs:_update: climateType=wakeup

Resulting error:
2019-08-29 11:30:38,819 [Controller] [ERROR] Unknown climateType='wakeup'
2019-08-29 11:30:38,822 [Controller] [ERROR] Exception in thread Controller:
Traceback (most recent call last):
File "/usr/local/lib/python3.7/threading.py", line 917, in _bootstrap_inner
self.run()
File "/usr/local/lib/python3.7/threading.py", line 865, in run
self._target(*self._args, **self._kwargs)
File "/usr/local/lib/python3.7/site-packages/pgc_interface/pgc_interface.py", line 797, in _parseInput
self.longPoll()
File "./ecobee-poly.py", line 204, in longPoll
self.updateThermostats()
File "./ecobee-poly.py", line 228, in updateThermostats
self.nodes[address].update(thermostat, fullData)
File "/app/nodeserver/node_types.py", line 284, in update
self._update()
File "/app/nodeserver/node_types.py", line 372, in _update
'GV3': self.getClimateIndex(climateType),
File "/app/nodeserver/node_types.py", line 401, in getClimateIndex
climateIndex = climateMap['unknown']
KeyError: 'unknown'

Just a guess at line 401 in node_types.py when name is not in climateMap it attempts to map 'unknown', which does not exist in node_funcs.py's climateList.

def getClimateIndex(self,name):
if name in climateMap:
climateIndex = climateMap[name]
else:
LOGGER.error("Unknown climateType='{}'".format(name))
climateIndex = climateMap['unknown']
return climateIndex

@jimboca
Copy link
Collaborator

jimboca commented Aug 29, 2019

Yes that is a bug I can fix, but it shouldn't get to that. Have you rebuilt the profile and restarted the nodeserver since the wakup mode was added?

@danvanklaveren
Copy link
Author

I have restarted the nodeserver a few times, but have not rebuilt the profile. I will try that and report back.

@jimboca
Copy link
Collaborator

jimboca commented Aug 29, 2019

Thanks. I think it's supposed to rebuild the profile in restart but I don't remember for sure. If you PM or email me the log package then I can review.

@jimboca jimboca self-assigned this Sep 6, 2019
@jimboca jimboca added this to the next_release milestone Sep 6, 2019
jimboca added a commit that referenced this issue Sep 8, 2019
@jimboca
Copy link
Collaborator

jimboca commented Sep 8, 2019

Fix released, please verify since I can't.

@danvanklaveren
Copy link
Author

danvanklaveren commented Sep 8, 2019 via email

@danvanklaveren
Copy link
Author

danvanklaveren commented Sep 9, 2019 via email

@jimboca
Copy link
Collaborator

jimboca commented Sep 9, 2019

Great, thanks for reporting and verifying.

@jimboca jimboca closed this as completed Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants