Implemented Dynamic island detection property. #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc: @Ekhoo |
kishorepran
reviewed
Apr 21, 2023
| extension Device { | ||
| static public var hasDynamicIsland: Bool { | ||
| switch version() { | ||
| case .iPhone14Pro, .iPhone14Pro_Max: |
There was a problem hiding this comment.
I would recommend to do as, because all the past models don't have it / will ever have in future.
case .iPhone14Pro, .iPhone14Pro_Max:
return false
default:
return false
There was a problem hiding this comment.
Hey @kishorepran ! Thank you for your feedback and recommendation. But if we'll use default case we can face some bugs in the near future, for example with current/my implementation when some contributors add new case (for example iPhone 15 Pro) Xcode shows an error/warning that we need to add this case inside hasDynamicIsland computed property and we don't forget it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I faced a case where I can detect dynamic island on iPhone. I also noticed that some developers also are interested in this case/issue on StackOverflow.
So I decided to implemented a new computed property for this great framework. Thanks.