Skip to content

Commit

Permalink
Specify phpunit version in composer. Simplify project files (#19)
Browse files Browse the repository at this point in the history
* Upgrade to latest phpunit

* Simplify

* Make phpunit 6 compatible

* fix
  • Loading branch information
Ekman committed Jul 9, 2019
1 parent a7d281e commit 16aaf99
Show file tree
Hide file tree
Showing 6 changed files with 13 additions and 36 deletions.
5 changes: 5 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,11 @@ nbproject/
.idea/
.php_cs.cache

# Eclipse
.buildpath
.project
.settings/

# Created by http://www.gitignore.io

### Composer ###
Expand Down
8 changes: 2 additions & 6 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,9 @@ php:
- 7.2
- 7.3

install:
- composer install --no-interaction --classmap-authoritative
- composer require --no-interaction php-coveralls/php-coveralls:^2.0
install: composer install --no-interaction --classmap-authoritative --no-suggest

script:
- chmod +x run-phpunit.sh
- ./run-phpunit.sh
script: vendor/bin/phpunit --configuration phpunit.xml

after_success: vendor/bin/php-coveralls --verbose

Expand Down
5 changes: 5 additions & 0 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -35,5 +35,10 @@
},
"require": {
"php": "^7.0"
},
"require-dev": {
"phpunit/phpunit": "^6.0",
"friendsofphp/php-cs-fixer": "^2.15",
"php-coveralls/php-coveralls": "^2.1"
}
}
12 changes: 0 additions & 12 deletions run-php-cs-fixer.sh

This file was deleted.

17 changes: 0 additions & 17 deletions run-phpunit.sh

This file was deleted.

2 changes: 1 addition & 1 deletion tests/LuhnAlgorithmTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ class LuhnAlgorithmTest extends TestCase
*/
private $luhn;

public function setUp()
protected function setUp()
{
parent::setUp();

Expand Down

0 comments on commit 16aaf99

Please sign in to comment.