Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional parameter to generate Fixed/Coninuous caster joint #100

Merged
merged 1 commit into from Jul 6, 2023

Conversation

BarceloChristian
Copy link
Collaborator

🎉 New feature

Closes #99

Summary

To improve simulations, the caster wheel must rotate freely when the robot moves
By default, the joint keeps fixed as of now. Alternatively, the option use_fixed_caster:=False can be used when generating the URDF from XACRO.

Test it

  • Build the repository (needed to update the imported xacro)
  • Move to andino.gazebo.xacro location (can be done with base description too)
  • Run:
xacro andino.gazebo.xacro > andino.xacro use_gazebo_ros_control:=False use_fixed_caster:=False
  • Check the caster structure is connected to the base link and the wheel using continuous joints.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if it affects the public API)

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Christian Barcelo <christianbarcelo@ekumenlabs.com>
@francocipollone
Copy link
Collaborator

Related to #79

Copy link
Collaborator

@francocipollone francocipollone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks for the contribution.

I think that this fix is quite simple and doesn't modify the default robot behavior.
Btw, in the future the swivel caster will be changed most probably by a ball caster.

@francocipollone francocipollone merged commit 61ce6d9 into humble Jul 6, 2023
3 checks passed
@francocipollone francocipollone deleted the cbarcelo/optional_caster_type branch July 6, 2023 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add option to generate Fixed or Continuous joint for caster wheel
2 participants