Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong if/unless wheel xacro #95

Merged
merged 1 commit into from Jul 6, 2023

Conversation

BarceloChristian
Copy link
Collaborator

🦟 Bug fix

Fixes #94

Summary

  • Wheel meshes are added twice when the scale is not defined because of an error in the common_xacros.urdf.xacro (same condition is used twice)

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if it affects the public API)

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Christian Barcelo <christianbarcelo@ekumenlabs.com>
Copy link
Collaborator

@francocipollone francocipollone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice catch!

@francocipollone francocipollone merged commit 96f28aa into humble Jul 6, 2023
3 checks passed
@francocipollone francocipollone deleted the cbarcelo/fix_wrong_wheel_xacro branch July 6, 2023 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Wrong xacro:if/unless definition for wheel's mesh
2 participants