Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds andino_control as dependency of andino_gazebo #118

Merged
merged 3 commits into from
Jul 13, 2023
Merged

Adds andino_control as dependency of andino_gazebo #118

merged 3 commits into from
Jul 13, 2023

Conversation

francocipollone
Copy link
Collaborator

🦟 Bug fix

Fixes #117

Summary

What the title says

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if it affects the public API)

@francocipollone
Adds andino_control as dependency of andino_gazebo
19f55b2 
Signed-off-by: Franco Cipollone <franco.c@ekumenlabs.com>
@francocipollone
Copy link
Collaborator Author

@elector102 Would that fix the issue?

@francocipollone francocipollone mentioned this pull request Jul 13, 2023
Closed
@francocipollone
Removes unnecessary dependencies
ba90439 
Signed-off-by: Franco Cipollone <franco.c@ekumenlabs.com>
@francocipollone
Removes extra package.
1234223 
Signed-off-by: Franco Cipollone <franco.c@ekumenlabs.com>
elector102
elector102 approved these changes Jul 13, 2023
View reviewed changes
Copy link
Collaborator

@elector102 elector102 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@francocipollone francocipollone merged commit db3a9bb into humble Jul 13, 2023
3 checks passed
@francocipollone francocipollone deleted the francocipollone/andino_gazebo_dep branch July 13, 2023 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elector102 elector102 elector102 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Andino Roadmap
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The dependencies are not well fulfilled.
2 participants
@francocipollone @elector102