Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include robot assembly #238

Draft
wants to merge 20 commits into
base: humble
Choose a base branch
from

Conversation

JesusSilvaUtrera
Copy link
Contributor

🎉 New feature

Closes #237

Summary

I have added to the README.md of the andino_hardware package the assembly steps.

Test it

Just check the README.md

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)

Note to maintainers: I will open the PR as a draft first to discuss what things to add, or whether the format is okay or not.

Copy link
Collaborator

@francocipollone francocipollone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Just dropped some comments 🚀

andino_hardware/README.md Outdated Show resolved Hide resolved
andino_hardware/README.md Outdated Show resolved Hide resolved
andino_hardware/README.md Outdated Show resolved Hide resolved
@@ -21,36 +19,37 @@ This package aims to provide the necessary information to the correct assembly o

## Assembly Process

Following you can see a photo with all the parts:
The steps to reproduce the mounting of the Andino are:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Being super obnoxious (nit ^10) 🤓 : I guess we can remove this line as the section and steps are self explanatory

Copy link
Collaborator

@francocipollone francocipollone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noticed the following: the size of the images.

In order to avoid having a heavyweight repo, could you try to compress the images even more? I think that having images up to 1mb would be enough. (in case we notice the quality is too bad we could be stretch up to 2mb).

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow 26 mb.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Btw I love the numbers for guiding.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I thought about it this morning too, I will do that tomorrow, let's see if the image with the numbers can be compressed uo to 2 mb and look good, with the others there shouldn't be any problem.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By the way, do you know which tool was used for the connections diagram? I was thinking of using GIMP to create it but just for curiosity.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

JesusSilvaUtrera and others added 9 commits May 10, 2024 11:04
Signed-off-by: JesusSilvaUtrera <jsilvautrera@gmail.com>
Signed-off-by: JesusSilvaUtrera <jsilvautrera@gmail.com>
Signed-off-by: JesusSilvaUtrera <jsilvautrera@gmail.com>
Signed-off-by: JesusSilvaUtrera <jsilvautrera@gmail.com>
… the parts

Signed-off-by: JesusSilvaUtrera <jsilvautrera@gmail.com>
Signed-off-by: JesusSilvaUtrera <jsilvautrera@gmail.com>
Signed-off-by: JesusSilvaUtrera <jsilvautrera@gmail.com>
Signed-off-by: JesusSilvaUtrera <jsilvautrera@gmail.com>
Signed-off-by: JesusSilvaUtrera <jsilvautrera@gmail.com>
JesusSilvaUtrera and others added 7 commits May 10, 2024 11:27
Signed-off-by: JesusSilvaUtrera <jsilvautrera@gmail.com>
…rera/andino into jesus/#237_assembly_process
Signed-off-by: JesusSilvaUtrera <jsilvautrera@gmail.com>
Signed-off-by: JesusSilvaUtrera <jsilvautrera@gmail.com>
Signed-off-by: JesusSilvaUtrera <jsilvautrera@gmail.com>
@francocipollone
Copy link
Collaborator

Just passing by, I haven't reviewed as it is a draft, let me know otherwise 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 💪 Approved
Development

Successfully merging this pull request may close these issues.

Include assembly process
2 participants