-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include robot assembly #238
base: humble
Are you sure you want to change the base?
Include robot assembly #238
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Just dropped some comments 🚀
andino_hardware/README.md
Outdated
@@ -21,36 +19,37 @@ This package aims to provide the necessary information to the correct assembly o | |||
|
|||
## Assembly Process | |||
|
|||
Following you can see a photo with all the parts: | |||
The steps to reproduce the mounting of the Andino are: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Being super obnoxious (nit ^10) 🤓 : I guess we can remove this line as the section and steps are self explanatory
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just noticed the following: the size of the images.
In order to avoid having a heavyweight repo, could you try to compress the images even more? I think that having images up to 1mb would be enough. (in case we notice the quality is too bad we could be stretch up to 2mb).
andino_hardware/docs/parts.png
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow 26 mb.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Btw I love the numbers for guiding.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I thought about it this morning too, I will do that tomorrow, let's see if the image with the numbers can be compressed uo to 2 mb and look good, with the others there shouldn't be any problem.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By the way, do you know which tool was used for the connections diagram? I was thinking of using GIMP to create it but just for curiosity.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super handmade. Check this: https://docs.google.com/drawings/d/1wummJPj3EJHSpB-iakCe97DVVQHOPI6oLSaNHQ7MesI/edit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks!
Signed-off-by: JesusSilvaUtrera <jsilvautrera@gmail.com>
Signed-off-by: JesusSilvaUtrera <jsilvautrera@gmail.com>
Signed-off-by: JesusSilvaUtrera <jsilvautrera@gmail.com>
Signed-off-by: JesusSilvaUtrera <jsilvautrera@gmail.com>
… the parts Signed-off-by: JesusSilvaUtrera <jsilvautrera@gmail.com>
Signed-off-by: JesusSilvaUtrera <jsilvautrera@gmail.com>
Signed-off-by: JesusSilvaUtrera <jsilvautrera@gmail.com>
Signed-off-by: JesusSilvaUtrera <jsilvautrera@gmail.com>
Signed-off-by: JesusSilvaUtrera <jsilvautrera@gmail.com>
c4e84cc
to
91786d9
Compare
Signed-off-by: JesusSilvaUtrera <jsilvautrera@gmail.com>
…rera/andino into jesus/#237_assembly_process
Signed-off-by: JesusSilvaUtrera <jsilvautrera@gmail.com>
Signed-off-by: JesusSilvaUtrera <jsilvautrera@gmail.com>
Signed-off-by: JesusSilvaUtrera <jsilvautrera@gmail.com>
Just passing by, I haven't reviewed as it is a draft, let me know otherwise 👍 |
Signed-off-by: JesusSilvaUtrera <jsilvautrera@gmail.com>
Signed-off-by: JesusSilvaUtrera <jsilvautrera@gmail.com>
🎉 New feature
Closes #237
Summary
I have added to the
README.md
of theandino_hardware
package the assembly steps.Test it
Just check the
README.md
Checklist
Note to maintainers: I will open the PR as a draft first to discuss what things to add, or whether the format is okay or not.