Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes xacro file starting with a comment. #91

Merged
merged 1 commit into from Jul 4, 2023
Merged

Fixes xacro file starting with a comment. #91

merged 1 commit into from Jul 4, 2023

Conversation

francocipollone
Copy link
Collaborator

🦟 Bug fix

Fixes a bug introduced at #83 (comment)

Summary

XACRO files can't start with a comment.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if it affects the public API)

@francocipollone
Fixes xacro file.
ba971c6 
Signed-off-by: Franco Cipollone <franco.c@ekumenlabs.com>
@francocipollone francocipollone mentioned this pull request Jul 4, 2023
Merged
5 tasks
@francocipollone francocipollone merged commit f376944 into humble Jul 4, 2023
3 checks passed
@francocipollone francocipollone deleted the francocipollone/fix_xacro branch July 4, 2023 23:57
@francocipollone francocipollone mentioned this pull request Jul 5, 2023
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olmerg olmerg Awaiting requested review from olmerg

Assignees
No one assigned
Labels
None yet
Projects
Andino Roadmap
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@francocipollone