Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build demos sequentially #4

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Build demos sequentially #4

wants to merge 1 commit into from

Conversation

hidmic
Copy link
Collaborator

@hidmic hidmic commented Feb 8, 2024

Precisely what the title says. beluga_demo_build crashed my OS on build, and I have an i7 and 32GB worth of RAM.

@hidmic hidmic requested a review from glpuga February 8, 2024 23:02
@glpuga
Copy link
Collaborator

glpuga commented Feb 9, 2024

That's weird. Both my computers have half that RAM and it does not crash with the current setup.

Do notice that the current setup has this to prevent the build from crashing due to memory (which did happen without this in my I9). With this the most I observed during build was about 8GB used.

I did not add sequential to the build process because it's so conservative. If we do use sequential, I recommend we remove the MAKEFLAGS variable from the environment.

@hidmic
Copy link
Collaborator Author

hidmic commented Feb 9, 2024

Do notice that the current setup has this to prevent the build from crashing due to memory (which did happen without this in my I9). With this the most I observed during build was about 8GB used.

MAKEFLAGS is indeed set 🤔

Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@glpuga
Copy link
Collaborator

glpuga commented Feb 10, 2024

Notice that I force pushed to this MR after squashing main.

@hidmic
Copy link
Collaborator Author

hidmic commented Feb 10, 2024

Alternatively, we could provide two build command aliases: the current one, plus another, sequential, for modest computers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants