You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Add system level tests, having them passing should give the same level of "confidence" that a PR is working than manually running an exemple (e.g. the bagfile example).
Additional considerations
Possible system tests to add:
Use nav2 system tests for localization.
Maybe contribute to nav2 so they can also be used with other external amcl implementations (?).
Having a system test in beluga, that reads recorded sensor/odometry/map data and feeds beluga amcl implementation, while checking the estimation is within some conditions.
The recorded format could be a bagfile:
If we want to keep beluga ROS agnostic, we should only compile those if the dependencies are available (i.e. rosbag2)
Altarnatively, we can use a ros agnostic rosbag reader.
That's one is the only one I know, and it's python only, which would make interfacing with a C++ test not that nice.
Though we could use that to postprocess bagfiles and record that in a format friendly for a pure C++ test (that doesn't have rosbag2 as a dependency).
The text was updated successfully, but these errors were encountered:
Fixes#127
## Summary
First iteration of system level tests.
Details:
* Reads data from bagfile.
* Uses beluga_amcl::OccupancyGrid wrapper.
* Unrelated fix to `MonteCarloLocalization2d`.
* Parameterized: both bagfile and particle filter implementation.
* Checks tolerance between ground truth and localization result.
It would maybe be better to measure RMSE and have a tolerance for that
(maybe also keeping the max tolerance).
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Description
Definition of done
Add system level tests, having them passing should give the same level of "confidence" that a PR is working than manually running an exemple (e.g. the bagfile example).
Additional considerations
Possible system tests to add:
Maybe contribute to nav2 so they can also be used with other external amcl implementations (?).
beluga
, that reads recorded sensor/odometry/map data and feeds beluga amcl implementation, while checking the estimation is within some conditions.The recorded format could be a bagfile:
beluga
ROS agnostic, we should only compile those if the dependencies are available (i.e.rosbag2
)That's one is the only one I know, and it's python only, which would make interfacing with a C++ test not that nice.
Though we could use that to postprocess bagfiles and record that in a format friendly for a pure C++ test (that doesn't have
rosbag2
as a dependency).The text was updated successfully, but these errors were encountered: