Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance comparison with nav2_amcl #142

Merged
merged 6 commits into from
Mar 20, 2023
Merged

Performance comparison with nav2_amcl #142

merged 6 commits into from
Mar 20, 2023

Conversation

ivanpauno
Copy link
Collaborator

@ivanpauno ivanpauno commented Mar 17, 2023 •
edited
Loading

Fixes #35.

Summary

  • Uploads report comparing nav2_amcl performance with beluga.
  • Uploads all benchmark assets obtained locally (added git-lfs support).
    Do we want that?
  • Some minor fixes and improvements to benchmarking script and docs.

Rendered report

Checklist

  • Read the contributing guidelines.
  • Configured pre-commit and ran colcon test locally.
  • Signed all commits for DCO.
  • Added tests (regression tests for bugs, coverage of new code for features).
  • Updated documentation (as needed).
  • Checked that CI is passing.

@ivanpauno
git-lfs config
3ed08bb 
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno
Add performance comparison report
3eb412a 
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno
Add git-lfs to CONTRIBUTING.md
31daaeb 
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno ivanpauno added documentation Improvements or additions to documentation enhancement New feature or request python Related to Python code labels Mar 17, 2023
@ivanpauno ivanpauno self-assigned this Mar 17, 2023
@ivanpauno ivanpauno changed the title Ivanpauno/performance comparison report Performance comparison with nav2_amcl Mar 17, 2023
nahueespinosa
nahueespinosa reviewed Mar 17, 2023
View reviewed changes
Copy link
Member

@nahueespinosa nahueespinosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ivanpauno Fantastic!

beluga_benchmark/docs/reports/2023-03-16/REPORT.md Outdated Show resolved Hide resolved
beluga_benchmark/docs/reports/2023-03-16/REPORT.md Outdated Show resolved Hide resolved
beluga_benchmark/docs/reports/2023-03-16/REPORT.md Outdated Show resolved Hide resolved
.gitattributes Outdated Show resolved Hide resolved
beluga_benchmark/docs/reports/2023-03-16/REPORT.md Outdated Show resolved Hide resolved
@ivanpauno
Address peer review comments
bc2ad58 
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno
Remove benchmark results assets
e54d1ba 
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno
Modify git-lfs settings
3106bb6 
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
nahueespinosa
nahueespinosa approved these changes Mar 20, 2023
View reviewed changes
Copy link
Member

@nahueespinosa nahueespinosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ivanpauno ivanpauno merged commit 7402ec2 into main Mar 20, 2023
@ivanpauno ivanpauno deleted the ivanpauno/performance-comparison-report branch March 20, 2023 21:22
@nahueespinosa nahueespinosa mentioned this pull request Mar 29, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glpuga glpuga glpuga left review comments

@nahueespinosa nahueespinosa nahueespinosa approved these changes

Assignees

@ivanpauno ivanpauno

Labels
documentation Improvements or additions to documentation enhancement New feature or request python Related to Python code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Compare performance between beluga_amcl and nav2_amcl
3 participants
@ivanpauno @glpuga @nahueespinosa