-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
beluga_system_test fails to pass #154
Comments
#142 introduced the usage of On latest
|
Should we consider not using |
@nahueespinosa alternatively, we can check if that is setup from the |
Sounds good to me! |
I think it's good to use it, but we don't have enough binaries for it to be really important.
SGTM! I think the main problem is that we weren't using it before, and now we're. I think it's also okay to remove |
Hard limit for files is 100MB. Our bagfile's size is 7.29MB, I'm not sure if we will want to store full datasets in this repo. I'd remove |
SGTM! |
SGTMT. |
Maybe put in assets the data required to maintain small the repo |
I think we can close this one. The question regarding using LFS can get it's own focused ticket. |
Related to #154. As the title says, 15MB doesn't justify using Git LFS yet. Signed-off-by: Nahuel Espinosa <nespinosa@ekumenlabs.com>
Required info
Steps to reproduce issue
Expected behavior
In
main
I'd expect the test to pass.Actual behavior
The test is unsuccessful.
The text was updated successfully, but these errors were encountered: