beluga_system_test fails to pass

[glpuga]

Required info

• Version or commit hash:
  • 56d20f4

Steps to reproduce issue

colcon build && colcon test

Expected behavior

In main I'd expect the test to pass.

Actual behavior

The test is unsuccessful.

[nahueespinosa]

#142 introduced the usage of git-lfs in this repository. The missing bagfile is probably related to that.

On latest main, I do get another error:

build/beluga_system_tests/test_results/beluga_system_tests/clang_format.xunit.xml: 1 test, 1 error, 0 failures, 0 skipped
- beluga_system_tests clang_format.xunit.missing_result
  <<< error message
    The test did not generate a result file:
    
    Could not find config file '.clang-format'
  >>>
build/beluga_system_tests/test_results/beluga_system_tests/clang_tidy.xunit.xml: 1 test, 1 error, 0 failures, 0 skipped
- beluga_system_tests clang_tidy.xunit.missing_result
  <<< error message
    The test did not generate a result file:
    
    Could not find config file '.clang-tidy'
  >>>

Summary: 776 tests, 2 errors, 2 failures, 154 skipped

[nahueespinosa]

Should we consider not using git-lfs to avoid this kind of issue? @ivanpauno

[glpuga]

Should we consider not using git-lfs to avoid this kind of issue? @ivanpauno

@nahueespinosa alternatively, we can check if that is setup from the run.sh script.

[nahueespinosa]

Sounds good to me!

[ivanpauno]

#142 introduced the usage of git-lfs in this repository. The missing bagfile is probably related to that.

I think it's good to use it, but we don't have enough binaries for it to be really important.
We're probably going to need it at some point if we start uploading more datasets for testing.

@nahueespinosa alternatively, we can check if that is setup from the run.sh script.

SGTM!

---

I think the main problem is that we weren't using it before, and now we're.
In that case you need to install git-lfs, install the lfs git hooks, and update the local repo to use the hook.
The dockerfile was updated to include git-lfs, so it shouldn't be a problem to commit from inside the container (after rebuilding it).
The contributing guidelines were also updated, so it shouldn't be a problem for someone doing a fresh start.

I think it's also okay to remove git-lfs though.

[nahueespinosa]

Hard limit for files is 100MB.

https://docs.github.com/en/repositories/working-with-files/managing-large-files/about-large-files-on-github.

Our bagfile's size is 7.29MB, I'm not sure if we will want to store full datasets in this repo.
For testing purposes, we can always trim the dataset/rosbag to what is needed for a specific test case.

I'd remove git-lfs for now.

[ivanpauno]

I'd remove git-lfs for now.

SGTM!

[glpuga]

SGTMT.

[olmerg]

Maybe put in assets the data required to maintain small the repo

[glpuga]

I think we can close this one. The question regarding using LFS can get it's own focused ticket.