Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing control to force a filter update on pose updates #248

Merged
merged 1 commit into from
Jul 22, 2023

Conversation

glpuga
Copy link
Collaborator

@glpuga glpuga commented Jul 15, 2023

Proposed changes

Major changes:

Minor changes:

  • Fix that ccache was not being used when building ROS 1.
  • Rename initialize_with_pose() in amcl_nodelet.xpp to reinitialize_with_pose(), which is the name of the same function in amcl_node.xpp. The old name also overloaded the name of a different function.

Type of change

  • 🐛 Bugfix (change which fixes an issue)
  • 🚀 Feature (change which adds functionality)
  • 📚 Documentation (change which fixes or extends documentation)

Checklist

Put an x in the boxes that apply. This is simply a reminder of what we will require before merging your code.

  • Lint and unit tests (if any) pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All commits have been signed for DCO

@glpuga glpuga force-pushed the glpuga/fix_pose_initializataion_lag branch 2 times, most recently from 618879f to cdfa2ad Compare July 15, 2023 22:48
@glpuga glpuga self-assigned this Jul 15, 2023
@glpuga glpuga force-pushed the glpuga/fix_pose_initializataion_lag branch from cdfa2ad to 859f8d4 Compare July 15, 2023 23:20
Copy link
Collaborator

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM at face value, but codecov ain't happy.

beluga_system_tests/test/test_system.cpp Outdated Show resolved Hide resolved
@glpuga
Copy link
Collaborator Author

glpuga commented Jul 17, 2023

Thanks for the review, will take a look in the evening.

@glpuga glpuga force-pushed the glpuga/fix_pose_initializataion_lag branch 4 times, most recently from 8a54666 to 53bbbc7 Compare July 22, 2023 19:11
Signed-off-by: Gerardo Puga <glpuga@ekumenlabs.com>
@glpuga glpuga force-pushed the glpuga/fix_pose_initializataion_lag branch from 53bbbc7 to 144b108 Compare July 22, 2023 19:41
@glpuga
Copy link
Collaborator Author

glpuga commented Jul 22, 2023

Code LGTM at face value, but codecov ain't happy.

The dislike is mutual.

Screenshot from 2023-07-22 16-43-50

@glpuga glpuga merged commit ff0d4ed into main Jul 22, 2023
12 checks passed
@glpuga glpuga deleted the glpuga/fix_pose_initializataion_lag branch July 22, 2023 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants