Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please clang-tidy on Ubuntu Noble #379

Merged
merged 2 commits into from
May 21, 2024
Merged

Please clang-tidy on Ubuntu Noble #379

merged 2 commits into from
May 21, 2024

Conversation

hidmic
Copy link
Collaborator

@hidmic hidmic commented May 21, 2024

Proposed changes

Follow-up to #378. This patch satisfies static analysis requirements on Jazzy CI

Type of change

  • 🐛 Bugfix (change which fixes an issue)
  • 🚀 Feature (change which adds functionality)
  • 📚 Documentation (change which fixes or extends documentation)

Checklist

  • Lint and unit tests (if any) pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All commits have been signed for DCO

@hidmic hidmic self-assigned this May 21, 2024
nahueespinosa
nahueespinosa approved these changes May 21, 2024
View reviewed changes
Copy link
Member

@nahueespinosa nahueespinosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from hidmic/jazzy-ci to main May 21, 2024 12:20
@hidmic
Please clang-tidy on Ubuntu Noble
4b3cd5f 
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@hidmic hidmic mentioned this pull request May 21, 2024
Merged
7 tasks
@hidmic
Fix -Wmaybe-uninitialized error
1bbea08 
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@hidmic hidmic merged commit 630f903 into main May 21, 2024
15 checks passed
@hidmic hidmic deleted the hidmic/tidy-jazzy branch May 21, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nahueespinosa nahueespinosa nahueespinosa approved these changes

@glpuga glpuga Awaiting requested review from glpuga

Assignees

@hidmic hidmic

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hidmic @nahueespinosa