Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ROS 2 Jazzy to CI/CD and dev workflows #378

Merged
merged 5 commits into from
May 21, 2024
Merged

Add ROS 2 Jazzy to CI/CD and dev workflows #378

merged 5 commits into from
May 21, 2024

Conversation

hidmic
Copy link
Collaborator

@hidmic hidmic commented May 20, 2024

Proposed changes

Precisely what the title says. This patch also fixes the tests that started failing with the transition.

Type of change

  • 🐛 Bugfix (change which fixes an issue)
  • 🚀 Feature (change which adds functionality)
  • 📚 Documentation (change which fixes or extends documentation)

Checklist

  • Lint and unit tests (if any) pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All commits have been signed for DCO

Additional comments

Here we exclude beluga_example and beluga_benchmark, as we cannot yet satisfy nav2 dependencies.

Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@hidmic hidmic requested a review from nahueespinosa May 20, 2024 20:54
@hidmic hidmic self-assigned this May 20, 2024
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@hidmic
Copy link
Collaborator Author

hidmic commented May 20, 2024

clang-tidy is a mess on Noble. Disabling it for Jazzy (see ecb20c6). I'll fix it in a follow-up PR.

@hidmic hidmic mentioned this pull request May 21, 2024
7 tasks
Copy link
Member

@nahueespinosa nahueespinosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hidmic hidmic merged commit 530d8b1 into main May 21, 2024
10 checks passed
@hidmic hidmic deleted the hidmic/jazzy-ci branch May 21, 2024 12:20
hidmic added a commit that referenced this pull request May 21, 2024
### Proposed changes

Follow-up to #378. This patch satisfies static analysis requirements on
Jazzy CI
 
#### Type of change

- [x] 🐛 Bugfix (change which fixes an issue)
- [ ] 🚀 Feature (change which adds functionality)
- [ ] 📚 Documentation (change which fixes or extends documentation)

### Checklist

- [x] Lint and unit tests (if any) pass locally with my changes
- [x] I have added tests that prove my fix is effective or that my
feature works
- [x] I have added necessary documentation (if appropriate)
- [x] All commits have been signed for
[DCO](https://developercertificate.org/)

---------

Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants