Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pages/use direct upload with continuous integration #3

Merged
merged 19 commits into from May 10, 2022

Conversation

Ekwuno
Copy link
Owner

@Ekwuno Ekwuno commented May 6, 2022

No description provided.

@cloudflare-pages
Copy link

cloudflare-pages bot commented May 6, 2022

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: c3f91c9
Status: ✅  Deploy successful!
Preview URL: https://8b16a493.cloudflare-docs-8og.pages.dev

View logs

Copy link

@eidam eidam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great! leaving a couple of comments from a first look


First log into the [Cloudflare dashboard](https://dash.cloudflare.com/profile/api-tokens) > **My Profile** > **API Tokens** > **Create Token** and under "Create Custom Token", select **Get started**. Start by naming the API Token, specify what product you are creating the API token for and give it the edit permission. In this case, select the "Account", "Cloudflare Pages" and "Edit":

![Select API token for Cloudflare Pages](../media/select-api-token-for-pages.png)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is too much whitespace in this screenshot. This needs to be cropped to delete extra whitespace.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The whitespace is just added by GitHub. It is not in the preview URL or when you download the image.
Screenshot 2022-05-09 at 13 12 30


On the CircleCI web app, go to your project's settings. You can navigate to "Projects" on the side navigation and click the ellipsis button in the project's row. You will see the option to add Environment variables:

![project setting env var](../media/project-settings-env-var-v2.png)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment about whitespace. Needs to be cropped to delete whitespace.

```


## Generate API Token from Cloudflare
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## Generate API Token from Cloudflare
## Generate an API token from Cloudflare

Ekwuno and others added 2 commits May 9, 2022 13:09
Co-authored-by: Kate Tungusova <70746074+deadlypants1973@users.noreply.github.com>

Select **Environment Variables** > **Add Environment Variable** and enter the name and value of the new environment variable, which is your Cloudflare credentials (`CLOUDFLARE_ACCOUNT_ID` and `CLOUDFLARE_API_TOKEN`).

### Setup
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is being set up here?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To keep it consistent, let's call it "Set up a workflow"

Co-authored-by: Kate Tungusova <70746074+deadlypants1973@users.noreply.github.com>
Ekwuno and others added 2 commits May 9, 2022 15:43
Co-authored-by: Kate Tungusova <70746074+deadlypants1973@users.noreply.github.com>
Co-authored-by: Kate Tungusova <70746074+deadlypants1973@users.noreply.github.com>
@Ekwuno Ekwuno merged commit fd52ddd into production May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants