Callbacks wrapper feature and bug fixes #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
ElChache
commented
Feb 19, 2020
ElChache
commented
- :callbacks-wrapper-fn can be passed in the configuration with the value as a function with signature [val ctx step-res] that will be called if a callback is a value instead of a function.
- fixed the bug that threw exception when the injector step returned nil
- fixed a bug that was calling the step callback functions with unresolved promises.
- :callbacks-wrapper-fn can be passed in the configuration with the value as a function with signature [val ctx step-res] that will be called if a callback is a value instead of a function. - fixed the bug that threw exception when the injector step returned nil - fixed a bug that was calling the step callback functions with unresolved promises.
johnp418
reviewed
Feb 20, 2020
johnp418
approved these changes
Feb 21, 2020
|
Okay I'll leave this to you now to merge it 👍 |
…s-wrapper-fn` is provided on the configuration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.