Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix style for displaying language in Prism #260

Merged
merged 1 commit into from
Sep 15, 2023
Merged

Fix style for displaying language in Prism #260

merged 1 commit into from
Sep 15, 2023

Conversation

dhruvkb
Copy link
Contributor

@dhruvkb dhruvkb commented Sep 15, 2023

Description 馃摉

This pull request fixes the CSS snippet for displaying language in the code preview generated by the @islands/prism plugin.

Background 馃摐

The included code snippet did not work because

  • the language div needs to be relatively positioned
  • the ::before pseudo-element needs two colons

The Fix 馃敤

By adding position: relative and the missing colon, these problems can be fixed.

Screenshots 馃摲

Screenshot 2023-09-15 at 3 02 30 PM

@ElMassimo
Copy link
Owner

Thanks Dhruv!

@ElMassimo ElMassimo merged commit 8fcd458 into ElMassimo:main Sep 15, 2023
4 of 5 checks passed
@dhruvkb dhruvkb deleted the patch-2 branch September 18, 2023 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dhruvkb @ElMassimo