fix: add rackup as a dependency
#13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for jekyll-vite canceled.
|
|
Hi! Had noticed your fork and the usage of |
ElMassimo
changed the title
rackup as a dependency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📖
This pull request fix a crash that occur when using
rack3.0.0Background 📜
This was happening because
rack3.0.0 has been release recently.rack-proxydoesn't fix therackversion, resulting in installing and using version 3.0.0 when runningbundle installfor the first time.This version introduce some breaking changes : in our case, rack handlers have been moved into a separate gem named
rackupThe Fix 🔨
Using the
rackupgem instead ofrackto get handlers.