-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Production build contains sourcemaps when they are turned off #49
Comments
Hi Dominik. Thanks for the report! I want the default to be consistent with what Rails does, but not being able to disable them explicitly is a bug. I'll make a fix to ensure that passing |
I read the linked thread comment, and as I understand the way they go, I think your project should follow defaults from the vite project, as it is just a wrapper on top of the Vite. Within the fix you mentioned, it still will be weird, that feature that should be turned off by default, is not. Also, in your documentation, you can read:
The only way you can understand that sentence is that whatever vite has in the config, it will work as the vite works. However, you may change the files, when they are generated by the project, so the configuration will have |
Released The default remains unchanged, as the advantages of generating source maps outweigh the disadvantages in most scenarios, it has better alignment with the Rails ecosystem, and it can be easily turned off now that the bug is fixed. I added a note in the docs explaining the decision. |
Thanks! |
bundle update vite_ruby
.Description 📖
bundle exec vite build
generates source maps, where vite as default has them turned off. Even settingbuild.sourcmap
tofalse
explicitly does not work. As the result, source maps are pushed to the production environment.The text was updated successfully, but these errors were encountered: