fix: allow providing an empty public output dir (close #161) #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: avoid matching all requests
ElMassimo
force-pushed
the
support-output-in-public
branch
from
1b616dc
to
1eaf455
Compare
This was referenced Jan 2, 2022
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 馃摉
This pull request adds support for providing an empty
publicOutputDir.Background 馃摐
For a while, the dev server proxy relied on
publicOutputDiras a "prefix" to detect requests for the Vite dev server.Now that Vite has patched bugs related to HMR requests, the proxy can rely on file existence.
The Fix 馃敤
Avoid adding slashes manually, or rely on
joinfrom the Node standard library.