fix: disable emptyOutDir in non-development modes #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElMassimo
reviewed
Apr 1, 2022
vite-plugin-ruby/src/index.ts
Outdated
| @@ -37,11 +37,11 @@ function config (userConfig: UserConfig, env: ConfigEnv): UserConfig { | |||
| const fs = { allow: [projectRoot], strict: true } | |||
| const server = { host, https, port, strictPort: true, fs } | |||
|
|
|||
| const isProduction = config.mode === 'production' | |||
| const isDevelopment = config.mode === 'development' | |||
There was a problem hiding this comment.
For the purpose of removing old assets in the local environment:
Suggested change
| const isDevelopment = config.mode === 'development' | |
| const isDevelopment = config.mode === 'development' || config.mode === 'test' |
|
Hi Antoine! @antoinematyja Looks great, thanks for your contribution! 😃 |
|
Released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📖
This pull request solves the issue discussed in #186
Staging mode was inconsistent with production mode
Background 📜
This was happening because the code was checking for
mode === 'production', but we need the same settings in all non-dev environments (not sure about CI but I guess?).The Fix 🔨
Replaced previous
isProductionwith!isDevelopment, also added a test but my test game is pretty bad, feel free to rework it