Allow to provide extra values to EnumCase attribute

[ogizanagi]

cc @IonBazan

https://github.com/Elao/PhpEnums/blob/enum-case-extras/README.md#extra-values

Would this fit to your needs?

[IonBazan]

Makes sense to me 💯
Would that be also possible to add a method to get the actual attribute instance to allow extending EnumCase attribute while still benefiting from the cache?

[ogizanagi]

Would that be also possible to add a method to get the actual attribute instance to allow extending EnumCase attribute while still benefiting from the cache?

Might be. But I think your use-case might be covered by:

/**
 * @final
 */
#[\Attribute(\Attribute::TARGET_CLASS_CONSTANT)]
class RenderableCase extends EnumCase
{
    public function __construct(string $label, string $color, string $icon)
    {
        parent::__construct($label, extra: compact('color', 'icon'))
    }
}

while still requiring only getExtra, if that's only about more scoped PHP attributes, isn't it?

[IonBazan]

My concern is type safety. With this extra: ['something' => 'test'] we are not sure what items and what types are stored there. If we could have a method that returns all attributes that extend EnumCase, we could store and retrieve any kind of extra information with ease and type safety.

Something like:

/**
 * @return EnumCase[]
 */
public function getAttributes(): array
{
    // ...
}

public function getColor(): ?string
{
    foreach ($this->getAttributes() as $attribute) {
        if ($attribute instanceof HasColor) {
            return $attribute->color;
        }
    }

    return null;
}

We could combine both approaches - for quick results, developers might use this extra field, but for more sophisticated logic, they might want to use the helper that returns the attributes assigned to the case.

[ogizanagi]

But the example in #170 (comment) is enough to provide type safety to me (unless you use both EnumCase and RenderableCase in your code base for the same needs, but that's not the point of creating a dedicated attribute then).

[ogizanagi]

(methods are private, but can be used by any userland implementation using this trait, as not marked @internal)