Update symfony 4 compatibility #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogizanagi
changed the title
- remove 3.2 - merge cs-fix with 3.4 build - merge 2.8 && deps=low build - sf 3.4 & 4.0 are not allowed to fail - php 7.2 with sf 4.0 - php 7.3 kept in allowed failures
chalasr
approved these changes
Nov 8, 2017
|
Thanks Benjamin. |
ogizanagi
added a commit
that referenced
this pull request
Nov 8, 2017
This PR was merged into the 1.x-dev branch. Discussion ---------- Update symfony 4 compatibility TODO: - [x] Update tests to use new PHPUnit namespaces - [x] Fix phpunit version used through env var - [x] Inject a `NullLogger` (see symfony/symfony#24385) Commits ------- 64fc69d Use new PhpUnit namespaces a4705a5 Inject a NullLogger for integration tests 46e775c Moar travis changes e438be5 Update symfony 4 compatibility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
NullLogger(see [FrameworkBundle] Register a NullLogger from test kernels symfony/symfony#24385)